Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): add more types to vue preset #281

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

dochner
Copy link
Contributor

@dochner dochner commented Sep 25, 2023

πŸ”— Linked issue

#278

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds ExtractDefaultPropTypes, ExtractPropTypes, ExtractPublicPropTypes exports in the vue preset file

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@antfu
Copy link
Member

antfu commented Sep 26, 2023

How often would you use cloneVNode and render in your Vue app?

@dochner
Copy link
Contributor Author

dochner commented Sep 26, 2023

I wouldn't use cloneVNode and render often in my Vue app. To be more precise, I'd use them sparingly, perhaps no more than five times. I'm gonna remove from the preset and import it locally.

@dochner dochner force-pushed the feat/increase-vue-preset-exports branch from c3af5b2 to bc78fde Compare September 26, 2023 07:53
@dochner dochner force-pushed the feat/increase-vue-preset-exports branch from bc78fde to f307aed Compare September 26, 2023 07:55
@antfu antfu changed the title feat: Increase vue preset exports feat(presets): add more types to vue preset Sep 26, 2023
@antfu antfu merged commit 9b8dac5 into unjs:main Sep 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants