Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: azure-storage-blob driver #154

Merged
merged 20 commits into from
Feb 27, 2023
Merged

feat: azure-storage-blob driver #154

merged 20 commits into from
Feb 27, 2023

Conversation

itpropro
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #154 (b339f66) into main (47c5e66) will decrease coverage by 1.43%.
The diff coverage is 76.96%.

❗ Current head b339f66 differs from pull request most recent head 3f153ed. Consider uploading reports for the commit 3f153ed to get more accurate results

@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   90.14%   88.72%   -1.43%     
==========================================
  Files          17       18       +1     
  Lines        1472     1650     +178     
  Branches      336      361      +25     
==========================================
+ Hits         1327     1464     +137     
- Misses        145      186      +41     
Impacted Files Coverage Δ
src/drivers/azure-storage-blob.ts 76.83% <76.83%> (ø)
src/index.ts 96.00% <100.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/drivers/azure-storage-blob.ts Outdated Show resolved Hide resolved
src/drivers/azure-storage-blob.ts Outdated Show resolved Hide resolved
@danielroe danielroe requested a review from pi0 February 20, 2023 21:21
@danielroe danielroe changed the title feat(driver): Added Azure blob storage driver feat(driver): azure blob storage driver Feb 20, 2023
itpropro and others added 3 commits February 20, 2023 22:28
Co-authored-by: Daniel Roe <daniel@roe.dev>
Co-authored-by: Daniel Roe <daniel@roe.dev>
Co-authored-by: Daniel Roe <daniel@roe.dev>
@pi0 pi0 changed the title feat(driver): azure blob storage driver feat: azure-storage-blob driver Feb 27, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work & LGTM. I think next steps we can enable raw support for this driver (which is probably it's main usesecause i guess)

@pi0 pi0 merged commit 5f64c7b into main Feb 27, 2023
@pi0 pi0 deleted the feat/azure-storage-blob branch February 27, 2023 16:31
@itpropro
Copy link
Member Author

Nice work & LGTM. I think next steps we can enable raw support for this driver (which is probably it's main usesecause i guess)

Yes, raw support would be a great next step and the driver would be perfectly fitted for that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants