-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generic type support #237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Live Preview ready!
|
Codecov Report
@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 80.76% 80.85% +0.09%
==========================================
Files 24 24
Lines 2682 2695 +13
Branches 446 445 -1
==========================================
+ Hits 2166 2179 +13
Misses 515 515
Partials 1 1
|
pi0
approved these changes
Jun 2, 2023
7 tasks
so1ve
pushed a commit
to so1ve/unstorage
that referenced
this pull request
Jul 8, 2023
* fix(prefixStorage): prefix `getItemRaw` and `setItemRaw` (unjs#232) * fix(github): fetchFiles should return files (unjs#229) * chore(deps): update all non-major dependencies (unjs#220) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update eslint * test: skip cloudflare-kv-http on node >= 18 * chore(release): v1.6.1 * docs: add social share image * chore: update deps * docs: fix typo (unjs#239) Change `environemnt` to `environment` Update cloudflare-kv-http.md * chore: update dependencies * feat: generic type support (unjs#237) * refactor: fix issues with typescript strict (unjs#250) * chore: add type check to ci * ci: skip flaky azure tests * chore(release): v1.7.0 * chore(deps): update all non-major dependencies * docs: fix typo (unjs#252) * chore(deps): update all non-major dependencies * test: add test for `github` driver (unjs#259) * feat: experimental operation batching (unjs#240) Co-authored-by: Pooya Parsa <pooya@pi0.io> * feat(cloudflare-kv): support `base` option for keys (unjs#261) * feat: `cloudflare-r2-binding` driver (unjs#235) * fix: add missing `cloudflareR2Binding` to the `builtinDrivers` * chore: update dev dependencies * chore(release): v1.8.0 * Fix typescript checks * add typehint * Install execa * Write test code * Remove not using import --------- Co-authored-by: 魔王少年 <q267009886.work@gmail.com> Co-authored-by: Andrei Dyldin <and@cesbo.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Pooya Parsa <pooya@pi0.io> Co-authored-by: Sébastien Chopin <seb@nuxt.com> Co-authored-by: Neelansh Mathur <53081208+neelansh15@users.noreply.github.com> Co-authored-by: 魔王少年 <q267009886.tw@gmail.com> Co-authored-by: Alex Duval <alexduval71@gmail.com> Co-authored-by: Hebilicious <xsh4k3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to have generics support,
This can enhance DX.
some examples
Regarding the inability to override,
perhaps it is overly restrictive? What do you think?
Also, my English is weak,
if there are any inaccuracies in the documentation,
anyone is welcome to modify it.