Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudflare-kv-binding): allow passing transaction options for setItem to binding.put #423

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

farnabaz
Copy link
Collaborator

@farnabaz farnabaz commented Apr 8, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Allowing to pass KVNamespacePutOptions via Unstroage's TransactionOptions

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 66.23%. Comparing base (4d61c78) to head (a1aecf3).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   65.05%   66.23%   +1.18%     
==========================================
  Files          39       39              
  Lines        4055     4058       +3     
  Branches      487      504      +17     
==========================================
+ Hits         2638     2688      +50     
+ Misses       1408     1361      -47     
  Partials        9        9              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 changed the title fix(Cloudflare KV): allow passing KV put-options via transaction-options fix(cloudflare-kv-binding): allow passing transaction options Apr 8, 2024
@pi0 pi0 changed the title fix(cloudflare-kv-binding): allow passing transaction options fix(cloudflare-kv-binding): allow passing transaction options for setItem to binding.put Apr 8, 2024
@pi0
Copy link
Member

pi0 commented Apr 8, 2024

Thanks for PR.

  1. Since it is not critical, expect delay in release
  2. We might later consider passing a namespace variant topts.cloudflare to the driver. so there might be breaking changes for this behavior beware.

@pi0 pi0 merged commit a3c752b into unjs:main Apr 8, 2024
4 checks passed
@sisou

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants