chore(deps): support @netlify/blobs v8 #486
Draft
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The peer dependency only specifies support for v6 and v7, but v8 works just fine. This adds v8 to the peer dependencies, bumps the dev dep to v8, updates the tests (there's a new requirement that's specific to unusual use cases like unstorage's tests, which are run outside of the Netlify platform and the Netlify CLI), and adjust the driver types to ensure compatibility with all supported versions. See netlify/blobs#183. I believe @netlify/blobs@8 will error in local dev when using netlify-cli before 17.21.1. This doesn't seem like unstorage's problem though, so I didn't do anything about that here.
serhalp
commented
Sep 15, 2024
| @@ -33,13 +33,19 @@ export interface NetlifyDeployStoreOptions extends NetlifyBaseStoreOptions { | |||
| deployID?: string; | |||
| } | |||
|
|
|||
| export interface NetlifyDeployStoreV8Options extends NetlifyDeployStoreOptions { | |||
| // TODO(serhalp) Export this type from @netlify/blobs instead | |||
There was a problem hiding this comment.
I'll leave this PR as a draft until I address this.
pi0
reviewed
Sep 16, 2024
| @@ -39,6 +39,8 @@ describe("drivers: netlify-blobs", async () => { | |||
| token, | |||
| siteID, | |||
| deployID: "test", | |||
| // Usually defaulted via the environment; only required in a test environment like this | |||
| region: "us-east-1", | |||
There was a problem hiding this comment.
Is there a fallback behavior if there is no env & default set?
There was a problem hiding this comment.
No, it bails. But that should only be possible when running outside of the Netlify platform or the Netlify CLI (which means Netlify Blobs wouldn't work anyway... so you wouldn't even get to here), or like I mentioned in the PR description if you're using an old version of the Netlify CLI (<17.21.1).
I'll look into making that error more actionable though. It should ideally tell users to upgrade to netlify-cli@latest if they're running through the CLI, instead of just saying region is missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The peer dependency only specifies support for v6 and v7, but v8 works just fine.
Closes #485.
This adds v8 to the peer dependencies, bumps the dev dep to v8, updates the tests (there's a new requirement that's specific to unusual use cases like unstorage's tests, which are run outside of the Netlify platform and the Netlify CLI), and adjust the driver types to ensure compatibility with all supported versions.
See netlify/blobs#183.
I believe @netlify/blobs@8 will error in local dev when using netlify-cli before 17.21.1. This doesn't seem like unstorage's problem though, so I didn't do anything about that here.