Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Embed component link settings #690

Closed
sarongebre opened this issue Apr 9, 2024 · 1 comment · Fixed by #691
Closed

Change Embed component link settings #690

sarongebre opened this issue Apr 9, 2024 · 1 comment · Fixed by #691
Assignees
@sarongebre
Labels
bug Something isn't working
Milestone
10.17

Comments

@sarongebre
Copy link
Collaborator

Check if it saves and displays right as it should on live sites.
@sarongebre sarongebre added the bug Something isn't working label Apr 9, 2024
@ericras ericras added this to the 10.17 milestone Apr 9, 2024
@ericras
Copy link
Member

ericras commented Apr 9, 2024 •
edited
Loading

I think for Embed we want to change https://cms-local.unl.edu/admin/structure/block-types/manage/embed/fields/block_content.embed.b_embed_link to only allow “External links only”. Stuff on the same site would use the “Node include” component.

@sarongebre sarongebre self-assigned this Apr 10, 2024
sarongebre added a commit to sarongebre/project-herbie that referenced this issue Apr 10, 2024
@sarongebre
Made link an external link, title tag to required, and changed help t…
e66d2c3 
…ext for the title field unlcms#690
@sarongebre sarongebre mentioned this issue Apr 10, 2024
Merged
ericras added a commit that referenced this issue Apr 25, 2024
@ericras
Merge pull request #691 from sarongebre/690-change-embed-component-li…
99d5631 
…nk-settings

Made link an external link, title tag to required, and changed help text for the title field #690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarongebre sarongebre

Labels
bug Something isn't working
Projects
None yet
Milestone
10.17
2 participants
@ericras @sarongebre