feat(smart-contracts): replace udt by governanceToken in Unlock contract
#14688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien51
reviewed
Sep 27, 2024
| @@ -81,8 +81,8 @@ contract Unlock is UnlockInitializable, UnlockOwnable { | |||
| // The WETH token address, used for value calculations | |||
| address public weth; | |||
|
|
|||
| // The UDT token address, used to mint tokens on referral | |||
| address public udt; | |||
There was a problem hiding this comment.
We should probably keep that and mark it as deprecated in favor of governanceToken to avoid breaking 3rd parties?
julien51
reviewed
Sep 27, 2024
smart-contracts/test/UPToken/swap.js
Outdated
| @@ -52,7 +52,7 @@ describe('Swapper UP / UDT', () => { | |||
| assert.equal(await swap.up(), await up.getAddress()) | |||
| }) | |||
| it('up is properly set', async () => { | |||
| assert.equal(await swap.udt(), await udt.getAddress()) | |||
| assert.equal(await swap.governanceToken(), await udt.getAddress()) | |||
julien51
requested changes
Sep 27, 2024
clemsos
commented
Sep 30, 2024
…col/unlock into rename-udt-governance-token
clemsos
commented
Sep 30, 2024
julien51
reviewed
Oct 4, 2024
julien51
approved these changes
Oct 4, 2024
Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces UDT with
governanceTokenin contractsIssues
Fixes #14658
Refs #
Checklist:
Release Note Draft Snippet