Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gov): proposal to set swap burner on mainnet and polygon #15092

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented Nov 15, 2024

Description

This PR adds a proposal to set the swap burner contract correctly on mainnet and polygon

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@unlock-deployer
Copy link
Collaborator

packages/networks/src/networks/zksync.ts

The setup is successful :

  • ✅ all mandatory keys are present
  • ✅ Subgraph up and running
  • ✅ Unlock ownership correctly set to the multisig

Some additonal warnings :

  • ⚠️ Skipping contract validation checks for packages/networks/src/networks/zksync.ts

1 similar comment
@unlock-deployer
Copy link
Collaborator

packages/networks/src/networks/zksync.ts

The setup is successful :

  • ✅ all mandatory keys are present
  • ✅ Subgraph up and running
  • ✅ Unlock ownership correctly set to the multisig

Some additonal warnings :

  • ⚠️ Skipping contract validation checks for packages/networks/src/networks/zksync.ts

@unlock-deployer
Copy link
Collaborator

packages/networks/src/networks/zksync.ts

The setup is successful :

  • ✅ all mandatory keys are present
  • ✅ Subgraph up and running
  • ✅ Unlock ownership correctly set to the multisig

Some additonal warnings :

  • ⚠️ Skipping contract validation checks for packages/networks/src/networks/zksync.ts

@clemsos
Copy link
Member Author

clemsos commented Nov 19, 2024

NB: the mainnet address for swapburner is a placeholder for now

Set SwapBurner in Unlock contract on Mainnet and Polygon

Goal of the proposal

This proposal sets the Swap Burner contract address in the main Unlock factory contract on the following chains: Ethereum,Polygon.

About this proposal

A SwapBurner helper contract has been deployed on both Mainnet and Polygon and will be added as setting to the main Unlock contract. This will enable the “swap and burn” feature of fees collected by the protocol on these chains, following the deployment of bridged versions of UDT there.

How it works

The proposal uses a cross-chain proposal pattern that, once passed, will send the calls to multiple chains at once. This pattern has been introduced and tested in a previous proposal.

The calls

This DAO proposal contains 2 calls:

Ethereum (1) 1 call

Changes sent to the Unlock contract at 0xe79B93f8E22676774F2A8dAd469175ebd00029FA

call setSwapBurner(0x52690873b22B0949A3A2c1AaD22653218460A002) and set the SwapBurner contract

Polygon (137) 1 call

Changes sent to the Unlock contract at 0xE8E5cd156f89F7bdB267EabD5C43Af3d5AF2A78f

call setSwapBurner(0x52690873b22B0949A3A2c1AaD22653218460A002) and set the SwapBurner contract

The Unlock Protocol Team

@unlock-deployer
Copy link
Collaborator

packages/networks/src/networks/zksync.ts

The setup is successful :

  • ✅ all mandatory keys are present
  • ✅ Subgraph up and running
  • ✅ Unlock ownership correctly set to the multisig

Some additonal warnings :

  • ⚠️ Skipping contract validation checks for packages/networks/src/networks/zksync.ts

1 similar comment
@unlock-deployer
Copy link
Collaborator

packages/networks/src/networks/zksync.ts

The setup is successful :

  • ✅ all mandatory keys are present
  • ✅ Subgraph up and running
  • ✅ Unlock ownership correctly set to the multisig

Some additonal warnings :

  • ⚠️ Skipping contract validation checks for packages/networks/src/networks/zksync.ts

@ccarfi
Copy link
Contributor

ccarfi commented Nov 19, 2024

i made two VERY minor changes to the copy.

@clemsos quick question — this proposal mentions "UDT" and not "UPToken." i wanted to double-check that is correct.

@unlock-deployer
Copy link
Collaborator

packages/networks/src/networks/zksync.ts

The setup is successful :

  • ✅ all mandatory keys are present
  • ✅ Subgraph up and running
  • ✅ Unlock ownership correctly set to the multisig

Some additonal warnings :

  • ⚠️ Skipping contract validation checks for packages/networks/src/networks/zksync.ts

1 similar comment
@unlock-deployer
Copy link
Collaborator

packages/networks/src/networks/zksync.ts

The setup is successful :

  • ✅ all mandatory keys are present
  • ✅ Subgraph up and running
  • ✅ Unlock ownership correctly set to the multisig

Some additonal warnings :

  • ⚠️ Skipping contract validation checks for packages/networks/src/networks/zksync.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants