fix!: Remove obsolete members

BREAKING CHANGE: Some obsolete members are now removed.
unoplatform · Apr 25, 2023 · 6b0b3d1 · 6b0b3d1
1 parent 54c43f3
commit 6b0b3d1
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 61 deletions.
diff --git a/src/Uno.UI.Foldable/FoldableApplicationViewSpanningRects.Android.cs b/src/Uno.UI.Foldable/FoldableApplicationViewSpanningRects.Android.cs
@@ -212,18 +212,6 @@ public bool? IsSpanned
 			}
 		}
 
-		/// <summary>
-		/// Legacy property - previously used to detect Surface Duo (only) via hardcoding. Currently synonymous with IsSpanned.
-		/// </summary>
-		[Obsolete("Prefer IsSpanned, since it provides a better experience on non-occluding folding features")]
-		public bool IsDualScreen
-		{
-			get
-			{
-				return IsSeparating;
-			}
-		}
-
 		public bool SupportsSpanning => HasFoldFeature || FoldableHingeAngleSensor.HasHinge;
 
 		public Rect Bounds

diff --git a/src/Uno.UI.Runtime.Skia.Wpf/WpfHost.cs b/src/Uno.UI.Runtime.Skia.Wpf/WpfHost.cs
@@ -117,20 +117,6 @@ internal static void RegisterExtensions()
 
 		internal WpfCanvas? NativeOverlayLayer => _nativeOverlayLayer;
 
-		/// <summary>
-		/// Creates a WpfHost element to host a Uno-Skia into a WPF application.
-		/// </summary>
-		/// <param name="appBuilder">App builder.</param>
-		/// <param name="args">Deprecated, value ignored.</param>		
-		/// <remarks>
-		/// Args are obsolete and will be removed in the future. Environment.CommandLine is used instead
-		/// to fill LaunchEventArgs.Arguments.
-		/// </remarks>
-		[EditorBrowsable(EditorBrowsableState.Never)]
-		public WpfHost(global::System.Windows.Threading.Dispatcher dispatcher, Func<WinUI.Application> appBuilder, string[]? args = null) : this(dispatcher, appBuilder)
-		{
-		}
-
 		public WpfHost(global::System.Windows.Threading.Dispatcher dispatcher, Func<WinUI.Application> appBuilder)
 		{
 			FocusVisualStyle = null;
@@ -387,10 +373,6 @@ public bool IgnorePixelScaling
 			}
 		}
 
-		[Obsolete("It will be removed in the next major release.")]
-		public SKSize CanvasSize
-			=> _renderer?.CanvasSize ?? SKSize.Empty;
-
 		protected override void OnRender(DrawingContext drawingContext)
 		{
 			base.OnRender(drawingContext);

diff --git a/src/Uno.UI/FeatureConfiguration.cs b/src/Uno.UI/FeatureConfiguration.cs
@@ -206,14 +206,6 @@ public static string SymbolsFont
 
 		public static class FrameworkElement
 		{
-			[Obsolete("This flag is no longer used.")]
-			[EditorBrowsable(EditorBrowsableState.Never)]
-			public static bool UseLegacyApplyStylePhase { get; set; }
-
-			[Obsolete("This flag is no longer used.")]
-			[EditorBrowsable(EditorBrowsableState.Never)]
-			public static bool ClearPreviousOnStyleChange { get; set; }
-
 #if __ANDROID__
 			/// <summary>
 			/// Controls the propagation of <see cref="Windows.UI.Xaml.FrameworkElement.Loaded"/> and
@@ -668,16 +660,6 @@ public static class WebView
 
 		public static class Xaml
 		{
-			/// <summary>
-			/// Maximal "BasedOn" recursive resolution depth.
-			/// </summary>
-			/// <remarks>
-			/// This is a mechanism to prevent hard-to-diagnose stack overflow when a resource name is not found.
-			/// </remarks>
-			[Obsolete("This flag is no longer used.")]
-			[EditorBrowsable(EditorBrowsableState.Never)]
-			public static int MaxRecursiveResolvingDepth { get; set; } = 12;
-
 			/// <summary>
 			/// By default, XAML hot reload will be enabled when building in debug. Setting this flag to 'true' will force it to be disabled.
 			/// </summary>

diff --git a/src/Uno.UI/UI/Xaml/VisibilityExtensions.cs b/src/Uno.UI/UI/Xaml/VisibilityExtensions.cs
@@ -10,14 +10,3 @@ public static class VisibilityExtensions
 	/// </summary>
 	public static bool IsHidden(this Visibility visibility) => visibility == Visibility.Collapsed;
 }
-
-[EditorBrowsable(EditorBrowsableState.Never)]
-[Obsolete("'VisiblityExtensions' is obsolete. Use 'VisibilityExtensions' instead.")]
-public static class VisiblityExtensions
-{
-	// This class is for binary compatibility before the typo was corrected in its name.
-	[EditorBrowsable(EditorBrowsableState.Never)]
-	[Obsolete("'VisiblityExtensions.IsHidden' is obsolete. Use 'VisibilityExtensions.IsHidden' instead.")]
-	public static bool IsHidden(Visibility visibility) => visibility.IsHidden();
-
-}
diff --git a/src/Uno.UWP/Devices/Sensors/Helpers/INativeDualScreenProvider.cs b/src/Uno.UWP/Devices/Sensors/Helpers/INativeDualScreenProvider.cs
@@ -5,8 +5,6 @@ namespace Uno.Devices.Sensors
 {
 	public interface INativeDualScreenProvider
 	{
-		bool IsDualScreen { get; }
-
 		bool? IsSpanned { get; }
 
 		bool SupportsSpanning { get; }