fix!: Remove [Get|Set][Left|Top|ZIndex] methods that take Dependenc…

…yObject from `Canvas`

BREAKING CHANGE: `GetLeft`, `GetTop`, `SetLeft`, `SetTop`, `GetZIndex`, and `SetZIndex` overloads that take DependencyObject are now removed. The UIElement overloads should be used instead.

build/PackageDiffIgnore.xml

@@ -9463,6 +9463,12 @@
 			<Member fullName="System.Void Windows.UI.Xaml.Controls.Primitives.Popup.OnVerticalOffsetChanged(System.Double oldVerticalOffset, System.Double newVerticalOffset)" reason="Api alignments" />
 			<Member fullName="System.Void Windows.UI.Xaml.Controls.RelativePanel.SetRightOf(Windows.UI.Xaml.UIElement view, System.Object value)" reason="Api alignments" />
 			<Member fullName="System.Void Windows.UI.Xaml.Controls.WebView.NavigateWithHttpRequestMessage(System.Net.Http.HttpRequestMessage requestMessage)" reason="Api alignments" />
+			<Member fullName="System.Double Windows.UI.Xaml.Controls.Canvas.GetLeft(Windows.UI.Xaml.DependencyObject obj)" reason="Api alignments" />
+			<Member fullName="System.Void Windows.UI.Xaml.Controls.Canvas.SetLeft(Windows.UI.Xaml.DependencyObject obj, System.Double value)" reason="Api alignments" />
+			<Member fullName="System.Double Windows.UI.Xaml.Controls.Canvas.GetTop(Windows.UI.Xaml.DependencyObject obj)" reason="Api alignments" />
+			<Member fullName="System.Void Windows.UI.Xaml.Controls.Canvas.SetTop(Windows.UI.Xaml.DependencyObject obj, System.Double value)" reason="Api alignments" />
+			<Member fullName="System.Double Windows.UI.Xaml.Controls.Canvas.GetZIndex(Windows.UI.Xaml.DependencyObject obj)" reason="Api alignments" />
+			<Member fullName="System.Void Windows.UI.Xaml.Controls.Canvas.SetZIndex(Windows.UI.Xaml.DependencyObject obj, System.Double value)" reason="Api alignments" />
 		</Methods>
 	</IgnoreSet>
 

src/Uno.UI.Tests/Windows_UI_XAML_Controls/CanvasTests/Given_Canvas.cs

@@ -84,7 +84,7 @@ public void When_CanvasPropertyConvert()
 			Assert.AreEqual(42d, SUT.GetValue(Canvas.TopProperty));
 
 			SUT.SetValue(Canvas.ZIndexProperty, "42");
-			Assert.AreEqual(42d, SUT.GetValue(Canvas.ZIndexProperty));
+			Assert.AreEqual(42, SUT.GetValue(Canvas.ZIndexProperty));
 		}
 	}
 }

src/Uno.UI/UI/Xaml/Controls/Canvas/Canvas.Android.cs

@@ -31,7 +31,7 @@ partial void MeasureOverridePartial()
 
 				var sorted = Children
 					.Select((view, childrenIndex) => (view, childrenIndex))
-					.OrderBy(tpl => tpl.view is DependencyObject obj ? Canvas.GetZIndex(obj) : 0); // Note: this has to be a stable sort
+					.OrderBy(tpl => tpl.view is UIElement obj ? Canvas.GetZIndex(obj) : 0); // Note: this has to be a stable sort
 
 				var drawOrder = 0;
 				foreach (var tpl in sorted)

src/Uno.UI/UI/Xaml/Controls/Canvas/Canvas.Layout.cs

@@ -45,19 +45,19 @@ protected override Size ArrangeOverride(Size finalSize)
 			{
 				if (child is _View childView)
 				{
-					var childAsDO = child as DependencyObject;
+					var childAsUIElement = child as UIElement;
 					var desiredSize = GetElementDesiredSize(childView);
 
 					var childRect = new Rect
 					{
-						X = GetLeft(childAsDO),
-						Y = GetTop(childAsDO),
+						X = GetLeft(childAsUIElement),
+						Y = GetTop(childAsUIElement),
 						Width = desiredSize.Width,
 						Height = desiredSize.Height,
 					};
 
 #if __IOS__
-					child.Layer.ZPosition = (nfloat)GetZIndex(childAsDO);
+					child.Layer.ZPosition = (nfloat)GetZIndex(childAsUIElement);
 #endif
 
 					ArrangeElement(child, childRect);

src/Uno.UI/UI/Xaml/Controls/Canvas/Canvas.cs

@@ -22,13 +22,6 @@ public partial class Canvas : Panel
 	{
 		#region Left
 
-		public static double GetLeft(DependencyObject obj)
-			=> GetLeftValue(obj);
-
-		public static void SetLeft(DependencyObject obj, double value)
-			=> SetLeftValue(obj, value);
-
-
 		[GeneratedDependencyProperty(DefaultValue = 0.0d, AttachedBackingFieldOwner = typeof(UIElement), Attached = true, Options = FrameworkPropertyMetadataOptions.AutoConvert | FrameworkPropertyMetadataOptions.AffectsArrange)]
 		public static DependencyProperty LeftProperty { get; } = CreateLeftProperty();
 
@@ -51,12 +44,6 @@ private static void OnLeftChanged(DependencyObject dependencyObject, DependencyP
 
 		#region Top
 
-		public static double GetTop(DependencyObject obj)
-			=> GetTopValue(obj);
-
-		public static void SetTop(DependencyObject obj, double value)
-			=> SetTopValue(obj, value);
-
 		[GeneratedDependencyProperty(DefaultValue = 0.0d, AttachedBackingFieldOwner = typeof(UIElement), Attached = true, Options = FrameworkPropertyMetadataOptions.AutoConvert | FrameworkPropertyMetadataOptions.AffectsArrange)]
 		public static DependencyProperty TopProperty { get; } = CreateTopProperty();
 
@@ -79,12 +66,6 @@ private static void OnTopChanged(DependencyObject dependencyObject, DependencyPr
 
 		#region ZIndex
 
-		public static double GetZIndex(DependencyObject obj)
-			=> GetZIndexValue(obj);
-
-		public static void SetZIndex(DependencyObject obj, double value)
-			=> SetZIndexValue(obj, value);
-
 		[GeneratedDependencyProperty(DefaultValue = 0.0d, AttachedBackingFieldOwner = typeof(UIElement), Attached = true, Options = FrameworkPropertyMetadataOptions.AutoConvert)]
 		public static DependencyProperty ZIndexProperty { get; } = CreateZIndexProperty();
 
@@ -111,16 +92,16 @@ public Canvas()
 
 		partial void InitializePartial();
 
-		public static double GetLeft(global::Windows.UI.Xaml.UIElement element) => GetLeft((DependencyObject)element);
+		public static double GetLeft(global::Windows.UI.Xaml.UIElement element) => GetLeftValue(element);
 
-		public static void SetLeft(global::Windows.UI.Xaml.UIElement element, double length) => SetLeft((DependencyObject)element, length);
+		public static void SetLeft(global::Windows.UI.Xaml.UIElement element, double length) => SetLeftValue(element, length);
 
-		public static double GetTop(global::Windows.UI.Xaml.UIElement element) => GetTop((DependencyObject)element);
+		public static double GetTop(global::Windows.UI.Xaml.UIElement element) => GetTopValue(element);
 
-		public static void SetTop(global::Windows.UI.Xaml.UIElement element, double length) => SetTop((DependencyObject)element, length);
+		public static void SetTop(global::Windows.UI.Xaml.UIElement element, double length) => SetTopValue(element, length);
 
-		public static int GetZIndex(global::Windows.UI.Xaml.UIElement element) => (int)GetZIndex((DependencyObject)element);
+		public static int GetZIndex(global::Windows.UI.Xaml.UIElement element) => GetZIndexValue(element);
 
-		public static void SetZIndex(global::Windows.UI.Xaml.UIElement element, int value) => SetZIndex((DependencyObject)element, value);
+		public static void SetZIndex(global::Windows.UI.Xaml.UIElement element, int value) => SetZIndexValue(element, value);
 	}
 }