Skip to content

Commit

Permalink
fix(lottie): Use a net8 compatible property for lottie/skiasharp dete…
Browse files Browse the repository at this point in the history
…ction

(cherry picked from commit 088ac8e)
  • Loading branch information
jeromelaban authored and mergify[bot] committed Oct 26, 2023
1 parent 0b7e581 commit c413d09
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<Target Name="_ValidateLottieDependencySkia"
BeforeTargets="CoreCompile"
Condition="'$(IsUnoHead)'=='true' and '$(UnoRuntimeIdentifier)'=='Skia'">
Condition="'$(IsUnoHead)'=='true' and '$(UnoRuntimeIdentifier)'=='Skia' and '$(UnoDisableLottieVersionCheck)'==''">

<!--
Nuget does not support dynamic references in packages, and we need Skottie only for the Skia UnoRuntime
Expand All @@ -21,8 +21,8 @@
<_SkiaSharpPackageName Condition="'$(MSBuildThisFile)'=='uno.winui.lottie.targets'">SkiaSharp.Views.Uno.WinUI</_SkiaSharpPackageName>
</PropertyGroup>
<ItemGroup>
<_SkiaSharpViewsRefs Include="@(RuntimeCopyLocalItems)" Condition="'%(RuntimeCopyLocalItems.NuGetPackageId)' == '$(_SkiaSharpPackageName)'" />
<_SkottieRefs Include="@(RuntimeCopyLocalItems)" Condition="'%(RuntimeCopyLocalItems.NuGetPackageId)' == 'SkiaSharp.Skottie'" />
<_SkiaSharpViewsRefs Include="@(ReferencePath)" Condition="'%(ReferencePath.NuGetPackageId)' == '$(_SkiaSharpPackageName)'" />
<_SkottieRefs Include="@(ReferencePath)" Condition="'%(ReferencePath.NuGetPackageId)' == 'SkiaSharp.Skottie'" />
</ItemGroup>

<Error Condition="'@(_SkiaSharpViewsRefs)'==''" Text="In order to use Uno Lottie support, the '$(_SkiaSharpPackageName)' NuGet Package (2.88.3 or later) must be referenced in the project. You can add &lt;PackageReference Include=&quot;$(_SkiaSharpPackageName)&quot; Version=&quot;2.88.3&quot; /> to your project." />
Expand Down

0 comments on commit c413d09

Please sign in to comment.