perf: Avoid calling ToString twice on the same StringBuilder

unoplatform · Feb 26, 2023 · c77884d · c77884d
1 parent 772427d
commit c77884d
Showing 1 changed file with 16 additions and 13 deletions.
diff --git a/src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs b/src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs
@@ -466,15 +466,16 @@ private string InnerGenerateFile()
 					{
 						BuildResourceDictionaryBackingClass(componentBuilder, topLevelControl);
 						BuildTopLevelResourceDictionary(componentBuilder, topLevelControl);
+					}
 
-						if (_useXamlReaderHotReload)
-						{
-							_generationRunFileInfo.SetAppliedTypes(_xamlAppliedTypes);
-							_generationRunFileInfo.ComponentCode = componentBuilder.ToString();
-						}
+					var componentCode = componentBuilder.ToString();
+					if (_useXamlReaderHotReload)
+					{
+						_generationRunFileInfo.SetAppliedTypes(_xamlAppliedTypes);
+						_generationRunFileInfo.ComponentCode = componentCode;
 					}
 
-					writer.AppendLineInvariantIndented("{0}", componentBuilder.ToString());
+					writer.AppendLineIndented(componentCode);
 				}
 				else
 				{
@@ -483,7 +484,7 @@ private string InnerGenerateFile()
 					{
 						var generationRunFileInfo = runFileInfo.GetRunFileInfo(_fileUniqueId);
 
-						writer.AppendLineInvariantIndented("{0}", generationRunFileInfo.ComponentCode);
+						writer.AppendLineIndented(generationRunFileInfo.ComponentCode);
 
 						foreach (var type in generationRunFileInfo.AppliedTypes)
 						{
@@ -533,15 +534,17 @@ private string InnerGenerateFile()
 									BuildComponentFields(componentBuilder);
 
 									BuildCompiledBindings(componentBuilder);
+								}
 
-									if (_useXamlReaderHotReload)
-									{
-										_generationRunFileInfo.SetAppliedTypes(_xamlAppliedTypes);
-										_generationRunFileInfo.ComponentCode = componentBuilder.ToString();
-									}
+								var componentCode = componentBuilder.ToString();
+
+								if (_useXamlReaderHotReload)
+								{
+									_generationRunFileInfo.SetAppliedTypes(_xamlAppliedTypes);
+									_generationRunFileInfo.ComponentCode = componentCode;
 								}
 
-								writer.AppendLineInvariantIndented("{0}", componentBuilder.ToString());
+								writer.AppendLineIndented(componentCode);
 							}
 							else
 							{