fix!: Remove ApplyCompiledBindings from code generated by `Dependency…

…ObjectGenerator` BREAKING CHANGE: `DependencyObjectGenerator` no longer generated an empty ApplyCompiledBindings method.
unoplatform · May 23, 2023 · fa87ac3 · fa87ac3
1 parent c29fff3
commit fa87ac3
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 20 deletions.
diff --git a/...enerators.netcore.Tests/DependencyObjectGeneratorTests/Given_DependencyObjectGenerator.cs b/...enerators.netcore.Tests/DependencyObjectGeneratorTests/Given_DependencyObjectGenerator.cs
@@ -174,16 +174,7 @@ public void RestoreBindings()
 	 		{
 	 			__Store.RestoreBindings();
 	 		}
-
-	 		/// <summary>
-	 		/// Obsolete method kept for binary compatibility
-	 		/// </summary>
-	 		[global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
-	 		[global::System.Runtime.CompilerServices.MethodImpl(global::System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
-	 		public void ApplyCompiledBindings()
-	 		{
-	 		}
-
+
 	 		private global::Uno.UI.DataBinding.ManagedWeakReference _selfWeakReference;
 	 		global::Uno.UI.DataBinding.ManagedWeakReference IWeakReferenceProvider.WeakReference
 	 		{

diff --git a/src/SourceGenerators/Uno.UI.SourceGenerators/DependencyObject/DependencyObjectGenerator.cs b/src/SourceGenerators/Uno.UI.SourceGenerators/DependencyObject/DependencyObjectGenerator.cs
@@ -536,15 +536,6 @@ public void RestoreBindings()
 	__Store.RestoreBindings();
 }}
 
-/// <summary>
-/// Obsolete method kept for binary compatibility
-/// </summary>
-[global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
-[global::System.Runtime.CompilerServices.MethodImpl(global::System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
-public void ApplyCompiledBindings()
-{{
-}}
-
 private global::Uno.UI.DataBinding.ManagedWeakReference _selfWeakReference;
 global::Uno.UI.DataBinding.ManagedWeakReference IWeakReferenceProvider.WeakReference
 {{

diff --git a/src/Uno.UI/UI/Xaml/FrameworkElement.netstd.cs b/src/Uno.UI/UI/Xaml/FrameworkElement.netstd.cs
@@ -27,7 +27,6 @@ public partial class FrameworkElement : IEnumerable
 		private protected sealed override void OnFwEltLoading()
 		{
 			OnLoadingPartial();
-			ApplyCompiledBindings();
 
 			void InvokeLoading()
 			{