Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetNeedsKeyboard public method in Window.macOS.cs does nothing #10972

Closed
Youssef1313 opened this issue Jan 13, 2023 · 2 comments
Closed

SetNeedsKeyboard public method in Window.macOS.cs does nothing #10972

Youssef1313 opened this issue Jan 13, 2023 · 2 comments
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Jan 13, 2023 •
edited
Loading

I can't see how this:

uno/src/Uno.UI/Controls/Window.macOS.cs

Lines 527 to 534 in 5ea5251

public static void SetNeedsKeyboard(NSView view, bool needsKeyboard)
{
if (view != null)
{
_attachedProperties.SetValue(view, NeedsKeyboardAttachedPropertyKey, (bool?)needsKeyboard);
}
}

will ever do anything. Both GetNeedsKeyboard and NeedsKeyboard methods are unused (and will be deleted in a PR where I remove unused private methods).

This is a breaking change since SetNeedsKeyboard is public
@Youssef1313 Youssef1313 added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jan 13, 2023
@Youssef1313 Youssef1313 mentioned this issue Jan 13, 2023
Open
@jeromelaban
Copy link
Member

@MartinZikmund may know.

@Youssef1313 Youssef1313 mentioned this issue Feb 5, 2023
Merged
6 tasks
@Youssef1313
Copy link
Member Author

#11197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeromelaban @Youssef1313