[Epic] Breaking changes roundup

[MartinZikmund]

High priority vNext

• Drop non-Skia macOS target
• Drop GTK target
• Drop Fluent V1 styles ([Breaking] fix: Drop Fluent V1 styles #14769)
• Drop UWP?

Low priority

• [BREAKING] chore: Make Current BaseActivity nullable #18582
• Remove EventsBubblingInManagedCode DP
• Remove RethrowNativeExceptions feature configuration
• Remove DefaultsStartingValueFromAnimatedValue
• build: Cleanup packages #17788
• build: Drop deprecated RemoteControl package #17797
• NavigatingCancelEventArgs ctor should not be public
• ComboBox.OnIsDropDownOpenChanged should probably be private protected (verify)
• ItemsControl.OnItemsChanged should have a IVectorChangedEventArgs parameter (and maybe not be protected, but rather private protected [verify this])
• PageStackEntry.SourcePageType setter should not be public
• Frame.BackStack setter should not be public
• WindowActivatedEventArgs.WindowActivationState has wrong type in Uno.WinUI
• Fix UserControl inheritance
• Make PropertyPath sealed (expected by the VS designer)
• Revert fix: Revert PropertyChangedParams change #17414
• XamlCompositionBrushBase.CompositionBrush should be protected
• Remove UseLegacyHitTest
• FlyoutBase.Close() should be removed. Users should use the public Hide() instead.
• FrameworkPropertyMetadata.DefaultUpdateSourceTrigger should be internal (or, better the whole FrameworkPropertyMetadata)
• Update SkiaSharp to 3.x
• Delete

  uno/src/Uno.UI/UI/Xaml/Automation/AutomationProperties.cs

  Line 44 in c347914

  public static void SetAccessibilityeView(DependencyObject element, AccessibilityView value)

• IMenu, IMenuPresenter, and ISubMenuOwner should not be public
• For discussion - deprecating the AdaptNative code-path for native element hosting in Android and iOS - causing weird edge cases, and we don't support it officially AFAIK (only explicitly via ContentControl)
• src/Uno.UI/UI/Xaml/Media/BrushConverter.cs should not be browsable (it probably needs to stay public, but users should not see it)
• Border.ChildProperty is not public in WinUI
• [Breaking change] [Skia/Wasm] Make DependencyObject a class #17099
• DoubleCollection shouldn't inherit List<T>. We should use composition instead of inheritance.
• CompositionSpriteShape.StrokeDashArray shouldn't have setter (probably not even internal, and its default value should be non-null, and return type shouldn't be annotated as nullable)
• Remove BypassCheckToCloseKeyboard and its logic from Window.iOS.cs (we should likely default to true behavior to align with other targets)
• Remove invalid ctors from ItemsControlAutomationPeer and SelectorAutomationPeer (keep only WinUI ones)
• CoreWebView2.DocumentTitle setter should be internal or private
• Remove WindowView.ios.cs
• Remove Uno.UI.DataBinding.BinderDetails (perf: Improve startup performance by trimming unused UITest exports #16757)
• Remove Microsoft.UI.Composition.DelegatedInkTrailVisual
• Remove UseInvalidateMeasurePath and UseInvalidateArrangePath feature flags. Being always-true shouldn't cause issues.
• Remove TextBox.OnVerticalContentAlignmentChanged override. Maybe make the base OnVerticalContentAlignmentChanged private protected instead of protected.
• In WinUI tree, UseSystemFocusVisuals should be on UIElement. But on UWP tree, it should be on Control.
• Remove feature flag IgnoreINPCSameReferences
• ContentPresenter.ContentTemplateRoot should not be public #16148
• Remove non-DP setter support. See Misc XAML generator fixes #16134
• Move Background from FrameworkElement to Control
• [Core] AsReadOnly<T> conflicts with System.Collections.Generic.CollectionExtensions uno.extensions#2225
• chore: Cleanup DependencyPropertyValuePrecedences #15684
• Remove legacy stuff: https://github.com/unoplatform/uno/tree/master/src/Uno.UI/UI/Xaml/Controls/ListViewBase/Legacy

• uno/src/Uno.UI.Composition/Composition/VisualInteractionSource.cs

  Lines 83 to 89 in 2544755

  	// IMPORTANT: The correct API is Microsoft.UI.Input.PointerPoint!
  	// Currently, Microsoft.UI.Input.PointerPoint is in Uno.UI assembly.
  	// Uno.UI.Composition doesn't have access to Uno.UI (the dependency is the other way around).
  	// For now, the API diverges from WinUI, and an implicit conversion operator will be provided to convert
  	// from Microsoft.UI.Input.PointerPoint to Windows.UI.Input.PointerPoint.
  	// In Uno 6, we will make a breaking change to match WinUI.
  	public void TryRedirectForManipulation(Windows.UI.Input.PointerPoint pointerPoint)

• Investigate whether clr-namespace: can work in WinUI under any scenario. If not, we should remove support for it.
• Remove PointerPoint.op_Explicit in Uno 6 #15508
• Remove Setter<T>
• Align TemplatedParent with WinUI #15749
• Consider removing UseLegacyContentAlignment as a breaking change in Uno 6 #14858
• [Breaking]: Remove unused feature flag ShowClippingBounds #14777
• Remove NSObjectExtensions.ValidateDispose
• Decide whether MaterializableList<T> should be internal?
• Remove empty methods RestoreBindings and ClearBindings #13046
• Default UseLegacyPrimaryLanguageOverride to false in Uno 5 #13704
• Implement ms-resource:/// conversion of XAML relative Uris parsing for non-framework types (RewriteUri in XamlFileGenerator)
• Fix parent type for RadioMenuFlyoutItem (and undo workaround in UWP SyncGenerator)
• [Breaking] Rename Uno.UI.Toolkit #12322
• Align FrameBufferHost namespace #13484
• Unseal Window on Uno.WinUI (part of Cannot derive from sealed type Window #5286)
• [breaking] Flyout.DataContext should not be publicly available #12491
• Android.Preferences.PreferenceManager is deprecated in API level 29 #1833
• Remove EnableExperimentalKeyboardFocus flag on Android (after Android TV PR is merged)
• ElevatedView defaults should show a shadow by default #7114
• IFrameworkTemplatePoolAware should be implement explicitly #13083
• DataContext should only be available on FrameworkElement #13201
• Would be nice to have - Enable nullable reference types by default #9964
• Remove support for Android native popups (if confirmed by @jeromelaban)
• Remove https://github.com/unoplatform/uno/blob/master/src/Uno.UI/Controls/StyleSelectorCollection.iOS.cs and https://github.com/unoplatform/uno/blob/master/src/Uno.UI/Controls/StyleSelector2.iOS.cs
• Align Window types with WinAppSDK #12577
• Rename LauchedStart and LauchedStop to be correct (Launched) #13709
• SetterBase.set_Property should be removed in Uno 6 #13050
• Confirm whether Duration.TimeSpan should be a field or property. #13096
• FrameworkElement and ContentControl shouldn't implement IEnumerable.
• Investigate whether IsStatusBarTranslucent in Window.Android.cs can be removed

• uno/src/Uno.UI/UI/Xaml/Media/Animation/ColorKeyFrameCollection.cs

  Lines 27 to 37 in 3e74597

  	public new int Count
  	{
  	get => base.Count;
  	set => throw new NotSupportedException();
  	}
  	public new bool IsReadOnly
  	{
  	get => base.IsReadOnly;
  	set => throw new NotSupportedException();
  	}

  there shouldn't be throwing setters.
• fix: WinUI sync generator #13867
• [Breaking change]: Remove ApplySettersBeforeTransition feature flag #13326
• Remove AdjustArrange as a breaking change in Uno 6 #14478
• Drop fluent V1 Drop fluent V1 #14765, switch to a non-versioned fluent library
• Remove src/Uno.UWP/Extensions/Vector2Extensions.cs in favor of Uno.Foundation VectorExtensions.cs
• TimePickerFlyoutPresenter should derive from Control not from FlyoutPresenter
• [BREAKING] fix!: Include original file extension in retargeted drawables on Android #15891
• Microsoft.Windows.ApplicationModel.Resources should not be in Uno.UI - either Uno.UWP or in a separate assembly altogether (MRT Core is now a isolated component of WinAppSDK)

In Progress (has open PR against the feature/breaking-changes branch)

• refactor: Adjust Android conditionals #12563
• refactor: BorderLayerRenderer #12593 (supersedes feat: FauxGradientBorderPresenter control #7649)
• [WIP] perf: Brush change subscription #12595 (supersedes [WIP] perf: Brush change subscription #12234)
• feat: App-specific ApplicationData on Skia #12596 (supersedes [WIP] feat: App-specific ApplicationData on Skia #12314)
• build: Run GenerateMixins before BeforeCompile #12600 (supersedes build: Run GenerateMixins before BeforeCompile #12557) (not really a breaking change, and can be done any time)

Merged to feature/breaking-changes (these are in Uno 5)

• ElevatedView's CornerRadius property is already declared in base Control - it should be enough to observe its changes (fix!: ElevatedView shouldn't have CornerRadius as it exists in the base Control class. #11162)
• [Skia] ApplicationData.Current.LocalFolder redirects to %appdata% #8910
• UIElementExtensions.Elevation breaks VS designer #5513
• UWPSyncGenerator should generate private constructor when appropriate #6895
• CreationCollisionOptions values are not aligned with WinRT (Uno Platform CreationCollisionOptions enum values do not match #10630) (fix!: Correct values of CreationCollisionOption enum #11169)
• HResult type should not be available in C# (fix!: Remove Windows.Foundation.HResult #11167)
• Control.GetImplementedRoutedEvents method should be removed (fix!: Remove Control.GetImplementedRoutedEvents #11165)
• fix!: Remove Windows.Storage.Streams.InMemoryBuffer #11170
• fix!: Removed SuspendingDeferral constructor that takes an Action #11171
• Deferral.Close should not be available in C# (according to docs) (fix!: Remove Windows.Foundation.IClosable and Deferral.Close #11163)
• IClosable should not be available in C# (fix!: Remove Windows.Foundation.IClosable and Deferral.Close #11163)
• Uno.Client.ICommandExtensions should most likely not be public (fix!: Make ICommandExtensions internal #11194)
• JavaObjectExtensions should most likely not be public (fix!: Make JavaObjectExtensions internal #11196)
• Uno.Extensions.UriExtensions should most likely not be public (fix!: Uno.Extensions.UriExtensions shouldn't be public #11193)
• SetNeedsKeyboard public method in Window.macOS.cs does nothing #10972 (fix!: Remove SetNeedsKeyboard from macOS #11197)
• CalendarDatePicker._dateChanged shouldn't be public #11136 (fix!: Remove CalendarDatePicker._dateChanged #11192)
• Geolocator: [Epic] Breaking changes roundup #8339 (comment) (fix!: Remove wrong GetGeopositionHistoryAsync overloads from Geolocator #11198)
• ContentPropertyAttribute.Name should be a field, not a property, to match Windows #10841 (fix!: Make ContentPropertyAttribute.Name field instead of a property. #11164)
• FontFamilyHelper.RemoveUri and RemoveHashFamilyName should not be public (fix!: Adjust FontFamilyHelper #11195)
• Make SolidColorBrushHelper internal #11127 (fix!: Make SolidColorBrushHelper internal #11168)

• uno/src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlCodeGeneration.cs

  Lines 871 to 873 in 4666c66

  	writer.AppendLineInvariant("[global::System.Obsolete(\"This method is provided for binary backward compatibility. It will always return null.\")]");
  	writer.AppendLineInvariant("[global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]");
  	writer.AppendLineInvariant("public static object FindResource(string name) => null;");

  (fix!: Remove always-null-returning FindResource from Xaml generated code #11341)
• Move PersonPicture to MUX namespace Move PersonPicture to MUX namespace #10701 (fix!: Move PersonPicture to MUX namespace #11343)
• ICoreWindowEvents should not be public (fix!: ICoreWindowEvents is made internal. #11339)
• Make the RegisterDefaultStyleXYZ methods in Style internal (fix!: Remove unneeded Style.RegisterDefaultStyleForType #11345)
• Remove Skia target host constructors with args parameter (it is ignored anyway) (

  uno/src/Uno.UI.Runtime.Skia.Linux.FrameBuffer/FramebufferHost.cs

  Lines 38 to 41 in 45c85c0

  	[EditorBrowsable(EditorBrowsableState.Never)]
  	public FrameBufferHost(Func<WUX.Application> appBuilder, string[] args) : this(appBuilder)
  	{
  	}

  uno/src/Uno.UI.Runtime.Skia.Gtk/GtkHost.cs

  Lines 76 to 79 in 45c85c0

  	[EditorBrowsable(EditorBrowsableState.Never)]
  	public GtkHost(Func<WUX.Application> appBuilder, string[] args) : this(appBuilder)
  	{
  	}

  ) (fix!: Remove constructor overloads that takes an unused args parameter #11351)
• Remove PanelExtensions.cs #11315 (fix!: Remove PanelExtensions #11342)
• OnVerticalOffsetChanged and OnHorizontalOffsetChanged should not be public in Popup (fix!: OnVerticalOffsetChanged and OnHorizontalOffsetChanged are no longer protected. #11355)
• WebView.NavigateWithHttpRequestMessage has wrong parameter type #11099 (fix!: Align WebView.NavigateWithHttpRequestMessage signature with UWP #11344)
• RelativePanel.Properties.cs methods have parameters with different name than WinUI (element vs view etc.) (fix!: Align RelativePanel methods parameter names #11350)
• Remove ViewHelper (fix(iOSmacOS): Obsolete the use of readonly fields #9126) (fix!: Remove ViewHelper.MainScreenScale and ViewHelper.IsRetinaDisplay #11352)
• FrameworkElement constructor should be protected (fix!: Make FrameworkElement constructors protected. #11354)
• Get rid of GetScreenSize method in ViewHelper.iOSmacOS.cs - rename to GetMainWindowSize and make internal (or remove altogether, as we will have multi-window support) (fix!: Make ViewHelper.GetScreenSize internal #11353)
• fix!: Remove unneeded BaseFragment class on Android #11401
• Remove obsolete feature configurations #11371 (fix!: Remove obsolete members #11432)
• Remove VisiblityExtensions #11372 (fix!: Remove obsolete members #11432)
• Remove IsDualScreen #11373 (fix!: Remove obsolete members #11432)
• Remove MustUseWebKitWebView #11374 (fix!: Remove obsolete members #11432)
• Remove CanvasSize #11375 (fix!: Remove obsolete members #11432)
• feat: Enable Rule CA2211 #10878
• Canvas.Get/Set{Direction} methods with DependencyObject parameters should not be public (or should be removed completely) (fix!: Remove [Get|Set][Left|Top|ZIndex] methods that take DependencyObject from Canvas #11340)
• fix!: Delete dead code and public APIs. #11510
• Make WpfTextViewTextBox internal and move it to Wpf instead of WPF namespace (was taken for 4.8 - Overlay TextBox improvements #10935)
• Change ShouldWriteErrorOnInvalidXaml default to true or remove completely #11476 (fix!: Default ShouldWriteErrorOnInvalidXaml to true. #11583)
• PropertyMetadata has wrong name in RegisterAttached #11754 (fix!: Update DependencyProperty.RegisterAttached to match WinUI parameter names #11770)
• Uno.UI.Web.WebErrorStatus should not exist and all references should use Windows.Web.WebErrorStatus instead. ([Breaking] fix!: Change WebErrorStatus namespace #12130)
• WebView Task<string> InvokeScriptAsync method should be removed, IAsyncOperation<string> version should be kept. [Breaking] fix!: Remove Task-based WebView.InvokeScriptAsync #12132
• [Breaking] fix!: IconElement constructor should be internal only #12129
• Enable strict XAML types resolution by default (avoids fuzzy matching to non fully qualified types) (fix!: Always use strict search #12135)
• Always use type strict search. (fix!: Always use strict search #12135)
• Fix parent type for RadialGradientBrush (and undo workaround in UWP SyncGenerator) (Adjust RadialGradientBrush base type to match UWP #7170) (fix!: Adjust RadialGradientBrush base type #12142)
• SetContentOffset and SetZoomScale in IUIScrollView can be removed and their implementations as well (fix!: Remove SetContentOffset and SetZoomScale from IUIScrollView #12134)
• Uno.UI.IndexPath should most likely not be public (fix!: Remove some types from public API #12133)
• Uno.UI.IResourcesService should most likely not be public (fix!: Remove some types from public API #12133)
• Uno.UI.Common.DelegateCommand should most likely not be public (fix!: Remove some types from public API #12133)
• Windows.Foundation.SizeConverter might not need to be public? (fix!: Remove some types from public API #12133)
• fix: Add missing ContentProperty attributes #10840
• Move ControlsResourcesVersion enum to Uno.UI (fix!: Move ControlsResourcesVersion to Uno.UI assembly #12175)
• Move GridExtensions to legacy namespace (fix!: Make GridExtensions internal #12174)
• fix!: Window.Visible setter should not be public #12177
• SimpleOrientationSensor should not schedule on Dispatcher #10905 (fix!: SimpleOrientationSensor should not schedule on Dispatcher #12203)
• Timeline should be expose IDisposable ( [Feature] Marquee Text Control CommunityToolkit/Labs-Windows#275) (fix!: Timeline shouldn't implement IDisposable #12201)
• SimpleOrientationSensor shouldn't directly implement ISensorEventListener #12206 (fix!: Avoid directly implementing ISensorEventListener on SimpleOrientationSensor on Android #12224)
• [WASM] There is a public FrameworkElement.IsEnabled defined which is not supported by WindowsAppSDK #9621 (fix!: Move IsEnabled property from FrameworkElement to Control #12153)
• Misc breaking changes #12227
• Remove WasmHttpHandler as a breaking change #12242 (fix!: Remove WasmHttpHandler #12249)
• AnimatedVisualPlayer and IAnimatedVisualSource and related classes should live in the MUX namespaces, not WUX (see 8742fb9 - these had to be removed from the Generated sources, because otherwise they would be used instead of the actual current implementations in the WUX namespace) (fix!: Lottie breaking changes #12111)
• CreateTheamableFromLottieAsset name is incorrect (fix!: Lottie breaking changes #12111)
• Lottie namespace for net 6 #11717 (fix!: Lottie breaking changes #12111)
• fix!: Remove focus-related properties from Control on WinUI-flavored builds #12268
• fix!: Delete BackButton on iOS #12267
• fix!: Remove ToggleButton.OnIsCheckedChanged #12266
• Remove IDisposable from MediaPlayerElement.cs (fix!: MediaPlayerElement shouldn't be IDisposable #12274)
• Make Windows.UI.Xaml.ResourceHelper internal (fix!: Remove ResourcesService and ResourceHelper #12197)
• Name property should not be on UIElement for Skia and WASM (move to FrameworkElement remove duplicated NameProperty) (fix!: Move Name and NameProperty from UIElement to FrameworkElement #12248)
• fix: Remove implicit conversion from string to Point #12070
• Remove LoadActions/UnloadActions (see with @ebariche) (fix!: Remove load actions #12287)
• PowerEase.Power must be double #11662 (fix!: Align EasingFunctionBase with WinUI #12214)
• EasingFunctionBase should implement the correct Ease overload #12213 (fix!: Align EasingFunctionBase with WinUI #12214)
• Ensure Sync Generator runs correctly against MUX version of PersonPicture and AnimatedVisualPlayer (Unskip some types in UWPSyncGenerator #12293)
• Measure/Arrange shouldn't be virtual (fix!: Change Measure/Arrange to not be virtual #12294)
• Move MenuBar and MenuBarItem and MenuBarFlyoutItem implementation from WUX namespace to MUX namespace and add warning for unsupported WUX version (fix!: Move MenuBar to MUX namespace #12113)
• fix!: Make OnImageOpened private instead of protected virtual #12436
• Move SwipeControl and SwipeItem and SwipeItemInvokedEventArgs and SwipeMode and SwipeItems and SwipeBehaviorOnInvoked implementation from WUX namespace to MUX namespace and add warning for unsupported WUX version (fix!: Move SwipeControl to MUX #12112)
• fix(SyncGenerator): Generate missing attributes #11254
• Remove empty generated ApplyCompiledBindings method from DependencyObjectGenerator #11241 (fix!: Remove ApplyCompiledBindings from code generated by DependencyObjectGenerator #11338)
• chore: Remove non-working caching unmodified xaml files #12589 (supersedes chore: Remove non-working caching unmodified xaml files #11452)
• Misc breaking changes #12588 (supersedes More API alignments and do symbol matching in UWPSyncGenerator #7249 and fix!: Misc breaking changes #12261)
• fix!: Remove OnWindowCreated from WinUI tree #12594 (supersedes fix!: Remove OnWindowCreated from WinUI tree #12196)
• feat: Skia lifecycle changes #12597 (supersedes Skia application lifecycle changes #12354)
• Remove all ocurrences of NET7_0_OR_GREATER (as we will be targeting only .NET7+ going forward) #13708
• Refactor shapes to remove legacy ArbritaryShapeBase on WASM #2983
• [Breaking] Unify namespaces and casing in GTK, WPF and FrameBuffer #12840

For which Platform:

All

[Youssef1313]

It might also be a good idea to not expose HtmlImage publicly

uno/src/Uno.UI/UI/Xaml/Controls/Image/Image.wasm.cs

Lines 17 to 22 in 88d7a40

	public class HtmlImage : UIElement
	{
	public HtmlImage() : base("img")
	{
	}
	}

It should be used only by Uno, I think

[Youssef1313]

@MartinZikmund I assume these will go into Uno 5 (next major release)? If so, should we have a branch to work on these earlier?

[MartinZikmund]

@MartinZikmund I assume these will go into Uno 5 (next major release)? If so, should we have a branch to work on these earlier?

I think that is a good idea, let's make PRs for them targeting this branch - https://github.com/unoplatform/uno/tree/dev/5.0-breaking-changes

GitHub

GitHub - unoplatform/uno at dev/5.0-breaking-changes

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported. - GitHub - unoplatform/uno at dev/5.0-breaking-changes

[jeromelaban]

For breaking changes let's use a branch named feature/breaking-changes instead, the CI is already setup properly.

[Youssef1313]

Great. I renamed the branch Martin created: https://github.com/unoplatform/uno/tree/feature/breaking-changes.

I'm going to start working on some of the changes soon.

GitHub

GitHub - unoplatform/uno at feature/breaking-changes

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported. - GitHub - unoplatform/uno at feature/breaking-changes