Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebView.NavigateWithHttpRequestMessage has wrong parameter type #11099

Closed
Youssef1313 opened this issue Jan 30, 2023 · 3 comments · Fixed by #11344
Closed

WebView.NavigateWithHttpRequestMessage has wrong parameter type #11099

Youssef1313 opened this issue Jan 30, 2023 · 3 comments · Fixed by #11344
Assignees
@MartinZikmund @Youssef1313
Labels
area/webview Categorizes an issue or PR as relevant to the WebView control difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working project/non-ui ⚙️ Categorizes an issue or PR as relevant to winrt (non-ui)

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Jan 30, 2023 •
edited
Loading

Current behavior

Parameter is of type System.Net.Http.HttpRequestMessage

uno/src/Uno.UI/UI/Xaml/Controls/WebView/WebView.cs

Line 147 in a911ec8

public void NavigateWithHttpRequestMessage(HttpRequestMessage requestMessage)

Expected behavior

Parameter is of type Windows.Web.Http.HttpRequestMessage

I added this to the breaking changes roundup issue #8339
@Youssef1313 Youssef1313 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jan 30, 2023
@Youssef1313 Youssef1313 mentioned this issue Jan 30, 2023
Open
@Youssef1313 Youssef1313 self-assigned this Jan 30, 2023
@jeromelaban jeromelaban added project/non-ui ⚙️ Categorizes an issue or PR as relevant to winrt (non-ui) and removed triage/untriaged Indicates an issue requires triaging or verification labels Jan 30, 2023
@jeromelaban
Copy link
Member

Can you specify which is the declaring type?

@Youssef1313 Youssef1313 added the area/webview Categorizes an issue or PR as relevant to the WebView control label Jan 30, 2023
@Youssef1313
Copy link
Member Author

WebView. I edited the issue and added a link to the exact source code line.

@jeromelaban jeromelaban changed the title NavigateWithHttpRequestMessage has wrong parameter type WebView.NavigateWithHttpRequestMessage has wrong parameter type Jan 30, 2023
@MartinZikmund MartinZikmund self-assigned this Jan 31, 2023
@MartinZikmund
Copy link
Member

Assigning this to me as well, as I am working on WebView changes

@Youssef1313 Youssef1313 mentioned this issue Feb 16, 2023
Merged
6 tasks
@Youssef1313 Youssef1313 linked a pull request Feb 16, 2023 that will close this issue
fix!: Align WebView.NavigateWithHttpRequestMessage signature with UWP #11344
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinZikmund MartinZikmund

@Youssef1313 Youssef1313

Labels
area/webview Categorizes an issue or PR as relevant to the WebView control difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working project/non-ui ⚙️ Categorizes an issue or PR as relevant to winrt (non-ui)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: Align WebView.NavigateWithHttpRequestMessage signature with UWP Youssef1313/uno
3 participants
@MartinZikmund @jeromelaban @Youssef1313