Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty generated ApplyCompiledBindings method from DependencyObjectGenerator #11241

Closed
Youssef1313 opened this issue Feb 8, 2023 · 0 comments · Fixed by #11338
Closed

Remove empty generated ApplyCompiledBindings method from DependencyObjectGenerator #11241

Youssef1313 opened this issue Feb 8, 2023 · 0 comments · Fixed by #11338
Assignees
@Youssef1313
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request

Comments

@Youssef1313
Copy link
Member

uno/src/SourceGenerators/Uno.UI.SourceGenerators/DependencyObject/DependencyObjectGenerator.cs

Lines 598 to 605 in 3022c02

/// <summary>
/// Obsolete method kept for binary compatibility
/// </summary>
[global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
[global::System.Runtime.CompilerServices.MethodImpl(global::System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
public void ApplyCompiledBindings()
{{
}}

@Youssef1313 Youssef1313 added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Feb 8, 2023
@Youssef1313 Youssef1313 mentioned this issue Feb 8, 2023
Open
@jeromelaban jeromelaban removed the triage/untriaged Indicates an issue requires triaging or verification label Feb 8, 2023
@Youssef1313 Youssef1313 self-assigned this Feb 10, 2023
@Youssef1313 Youssef1313 mentioned this issue Feb 16, 2023
Merged
6 tasks
@Youssef1313 Youssef1313 linked a pull request Feb 16, 2023 that will close this issue
fix!: Remove ApplyCompiledBindings from code generated by DependencyObjectGenerator #11338
Merged
6 tasks
@Youssef1313 Youssef1313 mentioned this issue May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Youssef1313 Youssef1313

Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: Remove ApplyCompiledBindings from code generated by DependencyObjectGenerator Youssef1313/uno
2 participants
@jeromelaban @Youssef1313