Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrimaryLanguageOverride setting shared between skia applications #12320

Closed
nickrandolph opened this issue May 17, 2023 · 1 comment
Closed

PrimaryLanguageOverride setting shared between skia applications #12320

nickrandolph opened this issue May 17, 2023 · 1 comment
Assignees
@Youssef1313
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification

Comments

@nickrandolph
Copy link
Contributor

Current behavior

Create two different applications
Set PrimaryLanguageOverride in one application
Run other application and not PrimaryLanguageOverride is also set.

Expected behavior

Applications maintain separate values for PrimaryLanguageOverride

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

Currently skia applications use a common location for all settings.
This will be resolved by this PR but as this is breaking changes, will be 5.0 timeline
Fix for PrimaryLanguageOverride would be to use an app specific key for looking up the settings value.
Furthermore this would also provide separation for local debugging wasm applications. Currently if you create and debug two wasm applications that happen to use the same port (eg https://localhost:5000), they will access the same settings and thus the same value for PrimaryLanguageOverride. Even in 5.0 timeline when the fix for skia appdata is merged, we should keep the app specific key for PrimaryLanguageOverride to avoid confusion when debugging wasm applications.
@nickrandolph nickrandolph added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels May 17, 2023
@Youssef1313 Youssef1313 added the area/skia ✏️ Categorizes an issue or PR as relevant to Skia label May 17, 2023
@Youssef1313 Youssef1313 mentioned this issue May 17, 2023
Closed
6 tasks
@jeromelaban
Copy link
Member

This is fixed in latest master, since settings storage is now app-id specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Youssef1313 Youssef1313

Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Read PrimaryLanguageOverride from an app-specific key Youssef1313/uno
3 participants
@nickrandolph @jeromelaban @Youssef1313