[WIP] feat: App-specific ApplicationData on Skia
#12314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/automation
Youssef1313
reviewed
May 17, 2023
Comment on lines
+96
to
+99
| foreach (char c in Path.GetInvalidFileNameChars()) | ||
| { | ||
| fileName = fileName.Replace(c, '_'); | ||
| } |
There was a problem hiding this comment.
Not super efficient, I'd guess.
MartinZikmund
changed the title
ApplicationData on SkiaApplicationData on Skia
MartinZikmund
force-pushed
the
dev/mazi/packageid-skia
branch
from
5098135
to
b807adc
Compare
github-actions
bot
added
platform/android 🤖
6 tasks
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for #12321 to be merged into breaking changes branch to avoid conflicts
TODO
PreferredWindowSizeusage to later in the lifecycle (separate PR)GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):