Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align FrameBufferHost namespace #13484

Closed
Tracked by #8339
Youssef1313 opened this issue Sep 1, 2023 · 4 comments · Fixed by #13690
Closed
Tracked by #8339

Align FrameBufferHost namespace #13484

Youssef1313 opened this issue Sep 1, 2023 · 4 comments · Fixed by #13690
Assignees
@Youssef1313
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification

Comments

@Youssef1313
Copy link
Member

Current behavior

FrameBufferHost namespace isn't consistent with GtkHost and WpfHost.

Expected behavior

Consistency.

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response
@Youssef1313 Youssef1313 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Sep 1, 2023
@Youssef1313 Youssef1313 self-assigned this Sep 1, 2023
@nickrandolph
Copy link
Contributor

nickrandolph commented Sep 1, 2023 •
edited
Loading

When this is fixed we'll need to update Samples and Template repositories (and probably Toolkit and Extensions since they both have sample projects)

@Youssef1313 Youssef1313 mentioned this issue Sep 2, 2023
Open
@Youssef1313 Youssef1313 mentioned this issue Sep 19, 2023
Merged
6 tasks
@jeromelaban
Copy link
Member

@Youssef1313 could you take a look at updating all the relevant uno.samples in the canary branch (There may not be that many), as well as updating uno.templates ?

@Youssef1313
Copy link
Member Author

Sure. I'll do that.

@Youssef1313
Copy link
Member Author

Youssef1313 commented Sep 22, 2023 •
edited
Loading

unoplatform/uno.templates#313
unoplatform/uno.extensions#1907
unoplatform/Uno.Samples#580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Youssef1313 Youssef1313

Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: Change FramebufferHost namespace Youssef1313/uno
3 participants
@nickrandolph @jeromelaban @Youssef1313