Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable AAPT2 in the Samples and the Uno Solution Template #1382

Closed
2 of 9 tasks
ghuntley opened this issue Aug 14, 2019 · 2 comments · Fixed by #3514
Closed
2 of 9 tasks

Re-enable AAPT2 in the Samples and the Uno Solution Template #1382

ghuntley opened this issue Aug 14, 2019 · 2 comments · Fixed by #3514
Assignees
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/solution-templates Categorizes an issue or PR as relevant to the solution template area/vswin Categorizes an issue or PR as relevant to Visual Studio for Windows help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/enhancement New feature or request platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform

Comments

@ghuntley
Copy link
Member

Current behavior

We disabled AAPT2 in #1186 and #1364 because of dotnet/android#3327

Expected behavior

When VSWIN ships dotnet/android#3327 we need to re-enable AAPT2 for:

  • The Android head of the SamplesApp
  • The Android head generated by the Uno Solution Template

Environment

Nuget Package: master

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • Windows
  • Build tasks

Visual Studio

  • 2017 (version: )
  • 2019 (version: )
  • for Mac (version: )

Relevant plugins

  • Resharper (version: )

Anything else we need to know?

Opening as a help wanted as the complexity is low and a good candidate for someone's first pull-request to the project. The following article is a good read about the differences between AAPT1 and AAPT2: https://connortumbleson.com/2018/02/19/taking-a-look-at-aapt2/

@ghuntley ghuntley added kind/enhancement New feature or request help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform area/vswin Categorizes an issue or PR as relevant to Visual Studio for Windows kind/performance labels Aug 14, 2019
@ghuntley ghuntley added area/solution-templates Categorizes an issue or PR as relevant to the solution template area/automation Categorizes an issue or PR as relevant to project automation labels Aug 14, 2019
@MatFillion
Copy link
Contributor

MatFillion commented Jan 15, 2020

I tried using aapt2 since dotnet/android#3327 was merged and released.
I've set <AndroidUseAapt2>true</AndroidUseAapt2> instead of false but issue still occurs.

I'm on VS2019 16.4 and Xamarin.Android 10.1.1.0.

The fix was released in VS2019 16.3 and Xamarin 10.0.0.43 according to this reply dotnet/android#3327 (comment)

We can repro with a simple "new uno app" from the app template (vsix)

@MatFillion
Copy link
Contributor

MatFillion commented Jan 15, 2020

Maybe the name is really invalid though, file failing is repos\App7\App7\App7.Shared\Assets\Square44x44Logo.targetsize-24_altform-unplated.png

That asset probably belongs in the UWP head and not in the shared project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/solution-templates Categorizes an issue or PR as relevant to the solution template area/vswin Categorizes an issue or PR as relevant to Visual Studio for Windows help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/enhancement New feature or request platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants