Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing a CommandBar changes another CommandBar on iOS #3017

Closed
2 of 12 tasks
jeanplevesque opened this issue Apr 17, 2020 · 0 comments · Fixed by #4287
Closed
2 of 12 tasks

Changing a CommandBar changes another CommandBar on iOS #3017

jeanplevesque opened this issue Apr 17, 2020 · 0 comments · Fixed by #4287
Assignees
@ajpinedam
Labels
kind/bug Something isn't working project/navigation-lifecycle 🧬 Categorizes an issue or PR as relevant to the navigation and lifecycle (NavigationView, AppBar, ...)
Milestone
3.2

Comments

@jeanplevesque
Copy link
Member

Current behavior

Changing the Background property on the CommandBar on Page1 while navigating to Page2 changes the CommandBar on Page2.

Expected behavior

Changing the CommandBar on Page1 doesn't affect the CommandBar of Page2.

How to reproduce it (as minimally and precisely as possible)

Run this sample on an iOS device.
Once the app is launched, tap the button.
The button navigates to Page2 and sets the background of the Page1's CommandBar to transparent. Howerver, we can see that Page2's CommandBar also becomes transparent.

Environment

Nuget Package:
Uno.UI
Package Version(s):
2.1.37
Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • macOS
  • Windows
  • Build tasks
  • Solution Templates

Visual Studio:

  • 2017 (version: )
  • 2019 (version: )
  • for Mac (version: )

Relevant plugins:

  • Resharper (version: )

Anything else we need to know?
@jeanplevesque jeanplevesque added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Apr 17, 2020
@francoistanguay francoistanguay added this to the 3.1 milestone Aug 29, 2020
@francoistanguay francoistanguay removed the triage/untriaged Indicates an issue requires triaging or verification label Aug 29, 2020
@francoistanguay francoistanguay removed this from the 3.1 milestone Aug 31, 2020
@agneszitte agneszitte added the project/navigation-lifecycle 🧬 Categorizes an issue or PR as relevant to the navigation and lifecycle (NavigationView, AppBar, ...) label Sep 21, 2020
@jeromelaban jeromelaban added this to the 3.2 milestone Oct 7, 2020
@ajpinedam ajpinedam self-assigned this Oct 8, 2020
ajpinedam added a commit to ajpinedam/uno that referenced this issue Oct 16, 2020
@ajpinedam
fix(iOS) CommandBar updates on navigation unoplatform#3017
9c01a8e
@ajpinedam ajpinedam mentioned this issue Oct 16, 2020
Merged
6 tasks
ajpinedam added a commit to ajpinedam/uno that referenced this issue Oct 17, 2020
@ajpinedam
fix(iOS): CommandBar updates on navigation unoplatform#3017
48d1b0a
ajpinedam added a commit to ajpinedam/uno that referenced this issue Oct 22, 2020
@ajpinedam
fix(iOS): CommandBar updates on navigation unoplatform#3017
af732b9
ajpinedam added a commit that referenced this issue Oct 22, 2020
@ajpinedam
Merge pull request #4287 from ajpinedam/dev.anpi/ios.commandbar.color
5c53c2f 
fix(iOS) CommandBar updates on navigation #3017
mergify bot pushed a commit that referenced this issue Oct 26, 2020
@ajpinedam
fix(iOS): CommandBar updates on navigation #3017
2762f9b 
(cherry picked from commit af732b9)

# Conflicts:
#	src/Uno.UI/Controls/CommandBarHelper.iOS.cs
jeromelaban pushed a commit that referenced this issue Oct 27, 2020
@ajpinedam @jeromelaban
fix(iOS): CommandBar updates on navigation #3017
b4db156 
(cherry picked from commit af732b9)

# Conflicts:
#	src/Uno.UI/Controls/CommandBarHelper.iOS.cs
jeromelaban added a commit that referenced this issue Oct 27, 2020
@jeromelaban
Merge pull request #4391 from unoplatform/mergify/bp/release/beta/3.1…
3cbc126 
…/pr-4287

fix(iOS) CommandBar updates on navigation #3017 (bp #4287)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajpinedam ajpinedam

Labels
kind/bug Something isn't working project/navigation-lifecycle 🧬 Categorizes an issue or PR as relevant to the navigation and lifecycle (NavigationView, AppBar, ...)
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

fix(iOS) CommandBar updates on navigation #3017 ajpinedam/uno
5 participants
@ajpinedam @jeromelaban @agneszitte @francoistanguay @jeanplevesque