Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The template 'Uno App Solution' 1.30.1 generates an invalid UWP appmanifest.xml #7

Closed
MarkStega opened this issue May 18, 2018 · 3 comments

Comments

@MarkStega
Copy link

The generated appmanifest.xml for the UWP project has the following:

<Identity Name="$guid1$" Publisher="CN=nventive" Version="1.0.0.0" ProcessorArchitecture="x86" /> <mp:PhoneIdentity PhoneProductId="1897f84c-689e-44d3-a8b7-c521a62818ae" PhonePublisherId="00000000-0000-0000-0000-000000000000" /> <Properties> <DisplayName>$targetnametoken$</DisplayName> <PublisherDisplayName>$targetnametoken$</PublisherDisplayName> <Logo>Assets\StoreLogo.png</Logo>

The $guid1$ generates the error in the build, but the $targetnametoken$ also appears to need expansion

@jeromelaban
Copy link
Member

Thanks mark, indeed, this is missing.

@MarkStega
Copy link
Author

It's an easy fix if you want to document without rushing a release - Just edit the Package.Appmanifest solution item and fill in sensible values where the $toekn$ entries are located...

@jeromelaban
Copy link
Member

Sure, manipulating the package works as well :) I've updated to 1.30.3, which fixes this.

NicolasChampagne added a commit that referenced this issue Jul 23, 2019
# This is the 1st commit message:

Fix to projitems files

# This is the commit message #2:

added suggestions from code review

# This is the commit message #3:

Added a class for DependencyProperty.UnsetValue

fix wip

# This is the commit message #4:

Fix to remove the "collection changed" exception

# This is the commit message #5:

DataContext were considered valid when set to "UnsetValue"
Was causing a problem on Android when coming back from background, the DataContext is briefly set to UnsetValue, causing DependencyProperties to change to their default value.

# This is the commit message #6:

Fixed exception when using ExponentialEase on Android

# This is the commit message #7:

Removed useless setting of DataContext in a "reload" scenario.
This was mostly happening on Android when the application is coming back from background.

# This is the commit message #8:

Reverted IShadowChildrenProvider to use the List<T> type
mergify bot pushed a commit that referenced this issue Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants