Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElevatedView defaults should show a shadow by default #7114

Open
12 tasks
Tracked by #6183
, #8339
...
jeromelaban opened this issue Sep 16, 2021 · 0 comments
Open
12 tasks
Tracked by #6183
, #8339
...

ElevatedView defaults should show a shadow by default #7114

jeromelaban opened this issue Sep 16, 2021 · 0 comments
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers kind/enhancement New feature or request project/shapes-brushes 🔶 Categorizes an issue or PR as relevant to shapes and brushes

Comments

@jeromelaban
Copy link
Member

What would you like to be added:

Change the defaults of ElevatedView to show a shadow so the users intuitively know it works:

uno/src/Uno.UI.Toolkit/ElevatedView.cs

Line 87 in fd0df4b

"Elevation", typeof(double), typeof(ElevatedView), new PropertyMetadata(default(double), OnChanged));

uno/src/Uno.UI.Toolkit/ElevatedView.cs

Line 125 in fd0df4b

new FrameworkPropertyMetadata(default(Brush), OnChanged)

Related:

Why is this needed:

For which Platform:

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • macOS
  • Skia
    • WPF
    • GTK (Linux)
    • Tizen
  • Windows
  • Build tasks
  • Solution Templates

Anything else we need to know?
@jeromelaban jeromelaban added kind/enhancement New feature or request project/shapes-brushes 🔶 Categorizes an issue or PR as relevant to shapes and brushes difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Sep 16, 2021
This was referenced Sep 16, 2021
Open
Merged
@MartinZikmund MartinZikmund changed the title ElevatedView defaults should show a shadow by default. ElevatedView defaults should show a shadow by default Jul 18, 2023
@MartinZikmund MartinZikmund added difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI labels Jul 18, 2023
@MartinZikmund MartinZikmund mentioned this issue Jul 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers kind/enhancement New feature or request project/shapes-brushes 🔶 Categorizes an issue or PR as relevant to shapes and brushes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MartinZikmund @jeromelaban