build: Refactor how pages are included #10960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
force-pushed
the
extras-page
branch
from
f904fdd
to
2bdb0b5
Compare
github-actions
bot
added
area/automation
Youssef1313
force-pushed
the
extras-page
branch
from
2bdb0b5
to
c940379
Compare
Youssef1313
changed the title
Youssef1313
force-pushed
the
extras-page
branch
3 times, most recently
from
6114d93
to
1444777
Compare
github-actions
bot
added
the
area/solution-templates
Youssef1313
force-pushed
the
extras-page
branch
8 times, most recently
from
0e41719
to
b3ef5a4
Compare
Youssef1313
force-pushed
the
extras-page
branch
from
b3ef5a4
to
1fd16bc
Compare
|
@jeromelaban @MartinZikmund Can you please take a look? |
MartinZikmund
approved these changes
Jan 21, 2023
6 tasks
|
@jeromelaban @MartinZikmund Is this ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is much more understandable and maintainable approach.
By default,
EnableAutomaticXamlPageInclusionis set to true inDirectory.Build.props(early in the build). Individual projects can set it conditionally or unconditionally to false. Then, pages are included later in the build process inDirectory.Build.targets. WhenEnableAutomaticXamlPageInclusionis set to true, a project can define page exclusions to exclude specific pages (conditionally or unconditionally)PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):