Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TextBox): Setting TextBox.Text to null should only throw in UWP #11113

Merged
merged 2 commits into from
Jan 31, 2023
Merged

fix(TextBox): Setting TextBox.Text to null should only throw in UWP #11113

merged 2 commits into from
Jan 31, 2023

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): closes #11031

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Jan 31, 2023
jeromelaban
jeromelaban approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

@jeromelaban jeromelaban merged commit 46b2708 into unoplatform:master Jan 31, 2023
@Youssef1313 Youssef1313 deleted the textbox-text-null branch January 31, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextBox.Text = null throws exception
2 participants
@Youssef1313 @jeromelaban