Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: ICoreWindowEvents is made internal. #11339

Merged
merged 2 commits into from
Feb 17, 2023
Merged

fix!: ICoreWindowEvents is made internal. #11339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eab6d2
fix!: `ICoreWindowEvents` is made internal.
Youssef1313 Feb 16, 2023
f54dd45
chore: Update PackageDiffIgnore
Youssef1313 Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build/PackageDiffIgnore.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9136,6 +9136,7 @@
<Member fullName="Windows.Storage.Streams.InMemoryBuffer reason="Windows.Storage.Streams.Buffer should be used." />
<Member fullName="Windows.Foundation.HResult" reason="Type is hidden in .NET and shouldn't be used" />
<Member fullName="Windows.Storage.Streams.InMemoryBuffer" reason="Windows.Storage.Streams.Buffer should be used." />
<Member fullName="Windows.UI.Core.ICoreWindowEvents" reason="Not needed publicly" />
<Member fullName="Uno.Extensions.JavaObjectExtensions" reason="Only needed internally" />
<Member fullName="Uno.Client.ICommandExtensions" reason="Only needed internally" />
<Member fullName="Uno.Extensions.UriExtensions" reason="Not needed publicly" />
Expand Down
4 changes: 1 addition & 3 deletions src/Uno.UWP/UI/Core/ICoreWindowEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
#if UNO_HAS_MANAGED_POINTERS
using System;
using System.Linq;

namespace Windows.UI.Core;

public interface ICoreWindowEvents
internal interface ICoreWindowEvents
{
void RaisePointerEntered(PointerEventArgs args);
void RaisePointerExited(PointerEventArgs args);
Expand Down
11 changes: 5 additions & 6 deletions src/Uno.UWP/UI/Core/ICoreWindowsEvents.iOS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
using System;

namespace Windows.UI.Core
namespace Windows.UI.Core;

internal interface ICoreWindowEvents
{
public interface ICoreWindowEvents
{
void RaiseKeyUp(KeyEventArgs args);
void RaiseKeyDown(KeyEventArgs args);
}
void RaiseKeyUp(KeyEventArgs args);
void RaiseKeyDown(KeyEventArgs args);
}