Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs - add expanded guide on platform-specific code, fix TOC links #1221

Merged
merged 8 commits into from
Jul 16, 2019
Merged

Docs - add expanded guide on platform-specific code, fix TOC links #1221

merged 8 commits into from
Jul 16, 2019

Conversation

davidjohnoliver
Copy link
Contributor

GitHub Issue (If applicable): #

  • Add in-depth guides on handling platform-specific code and understanding shared project structure
  • Add script to check TOC file used to generate website
  • Add missing .mds to TOC, fix dead link

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@davidjohnoliver
Docs - add guides on platform-specific code
b7fe102 
Explains in detail how to manage platform-specific implementations with Uno, and also covers how shared projects work for the uninitiated.
@davidjohnoliver
Docs - add script to check TOC links
e4f5cba 
Reports dead links and unlinked articles. These should be fixed in toc.yml.
@davidjohnoliver
Docs - fix TOC and clean up
be59e91 
 - add missing docs to TOC
 - fix bad link
 - remove duplicated doc (dup of issue-triage.md)
@davidjohnoliver
Docs - add xaml prefix screenshot
2668f85
@davidjohnoliver
Docs - tweak screenshot
e832f3f
ghuntley
ghuntley approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@ghuntley ghuntley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely high value pull-request. :shipit:

image

ps. I've been thinking about information hierarchy and URL structure within our documentation. Will raise a GitHub issue later today and dump my brain / seek feedback.

doc/articles/check_toc.ps1 Show resolved Hide resolved
src/Uno.UWPSyncGenerator/DocGenerator.cs Show resolved Hide resolved
@ghuntley
Copy link
Member

ghuntley commented Jul 11, 2019 •
edited
Loading

Opened up initial thoughts at #1225. Need to think a little bit more about URL structure. Subscribe to that PR for updates on this topic. LGTM to merge this PR once [Uno app template]() is fixed.

jeromelaban
jeromelaban approved these changes Jul 16, 2019
View reviewed changes
doc/articles/platform-specific-csharp.md Outdated Show resolved Hide resolved
doc/articles/platform-specific-xaml.md Show resolved Hide resolved
doc/articles/uno-app-solution-structure.md Outdated Show resolved Hide resolved
doc/articles/uno-app-solution-structure.md Show resolved Hide resolved
@davidjohnoliver @jeromelaban
Docs - suggestions from code review
08cd259 
Co-Authored-By: Jérôme Laban <jerome.laban@nventive.com>
@davidjohnoliver davidjohnoliver merged commit b9a73ce into master Jul 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the dev/djo/docs-platform-specific branch July 16, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghuntley ghuntley ghuntley approved these changes

@jeromelaban jeromelaban jeromelaban approved these changes

@MatFillion MatFillion Awaiting requested review from MatFillion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidjohnoliver @ghuntley @jeromelaban