fix: Update WebView history properties on JS-based navigation
#12907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform/android 🤖
…y changes When JS-based navigation changes the history properties, we can't recognize this in WebView using conventional navigation events. However, it should still influence history properties.
MartinZikmund
force-pushed
the
dev/mazi/webview-navigation-behavior
branch
from
0638fbd
to
89ca036
Compare
|
The build 86148 found UI Test snapshots differences: Details
|
jeromelaban
approved these changes
Jul 18, 2023
|
@Mergifyio backport release/stable/4.9 |
✅ Backports have been created
|
jeromelaban
added a commit
that referenced
this pull request
Jul 19, 2023
…4.9/pr-12907 fix: Update `WebView` history properties on JS-based navigation (backport #12907)
|
@Mergifyio backport legacy/4x |
✅ Backports have been created
|
MartinZikmund
added a commit
that referenced
this pull request
Jul 28, 2023
fix: Update `WebView` history properties on JS-based navigation (backport #12907)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Copilot Summary
🤖 Generated by Copilot at 0638fbd
This pull request improves the web view controls for the Uno platform by adding a dispatcher property to the IWebView interface, implementing it for the WebView and WebView2 controls, and fixing some issues with the history management and event raising of the native web view classes. It also adds a new sample page to the UITests.Shared project to demonstrate the navigation properties of the WebView2 control.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):