TextBox - reset Text when pushing null to bound value #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix regression where a null pushed to Text via binding was being ignored, rather than clearing the Text.
davidjohnoliver
requested review from
MartinZikmund,
carldebilly and
jeromelaban
MartinZikmund
approved these changes
Jul 25, 2019
carldebilly
reviewed
Jul 26, 2019
| public void When_Binding_Set_Null() | ||
| { | ||
| var textBox = new TextBox(); | ||
| var source = new MySource() { SourceText = "Spinach" }; |
carldebilly
approved these changes
Jul 26, 2019
| set { | ||
| if (value == null) | ||
| { | ||
| throw new ArgumentNullException(); |
There was a problem hiding this comment.
Is it the behavior of UWP? Surprising...
|
/azp run |
carldebilly
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression where a null pushed to Text via binding was being ignored, rather than clearing the Text.
GitHub Issue (If applicable): fixes #1302
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):