Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to infinite loop with listviewHeaders #1307

Merged
merged 5 commits into from
Aug 2, 2019
Merged

Fix to infinite loop with listviewHeaders #1307

merged 5 commits into from
Aug 2, 2019

Conversation

NicolasChampagne
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Internal Issue (If applicable):
https://nventive.visualstudio.com/Umbrella/_workitems/edit/158362

@NicolasChampagne NicolasChampagne added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform labels Jul 26, 2019
@ghuntley
Copy link
Member

Thanks for adding the labels :)

@NicolasChampagne NicolasChampagne added ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 29, 2019
@NicolasChampagne
Copy link
Contributor Author

/azp run

@NicolasChampagne
Copy link
Contributor Author

/azp run

@juliecantin
Copy link
Contributor

juliecantin commented Aug 2, 2019 •
edited by unfurl-links bot
Loading

This PR also fixes the following internal issue, which has to do with group headers
https://nventive.visualstudio.com/Umbrella/_workitems/edit/158452

@NicolasChampagne NicolasChampagne merged commit dbda38f into master Aug 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the dev/nich/listview-head-loop branch August 2, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban left review comments

@davidjohnoliver davidjohnoliver davidjohnoliver approved these changes

@MatFillion MatFillion Awaiting requested review from MatFillion

Assignees
No one assigned
Labels
platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NicolasChampagne @ghuntley @juliecantin @jeromelaban @davidjohnoliver