Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored Drawable helper to Uno project #1308

Merged
merged 17 commits into from
Aug 9, 2019
Merged

Refactored Drawable helper to Uno project #1308

merged 17 commits into from
Aug 9, 2019

Conversation

MartinZikmund
Copy link
Member

GitHub Issue (If applicable): #1306

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

Drawable helper is available through ImageSource.Android in Uno.UI.

What is the new behavior?

A dedicated DrawableHelper was added to Uno project so that drawables can be retrieved from there as well (required for JumpListItem icons in #1306)

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@MartinZikmund MartinZikmund mentioned this pull request Jul 27, 2019
Merged
7 tasks
@davidjohnoliver
Copy link
Contributor

BindableImageSource looks like straight-up dead code - internal class, not referenced anywhere else, go ahead and delete it entirely. :)

@MartinZikmund
Copy link
Member Author

@davidjohnoliver done 👍

@jeromelaban
Copy link
Member

/azp run

@MartinZikmund
Copy link
Member Author

MartinZikmund commented Jul 29, 2019 •
edited
Loading

Fixed the problems, now should build ok

@MartinZikmund
Copy link
Member Author

/azp run

@ghuntley
Copy link
Member

Like magic, it works!

@MartinZikmund
Copy link
Member Author

@ghuntley Seems the build doesn't start 🤔

@jeromelaban
Copy link
Member

It will now, I missed an option. Can you retry ?

@MartinZikmund
Copy link
Member Author

/azp run

@jeromelaban
Copy link
Member

Not sure /azp run will work, but try pushing an update, or a rebase.

@MartinZikmund
Copy link
Member Author

Oh there it is 😃 ! Thank you both!

@ghuntley ghuntley added platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform kind/cleanup labels Aug 1, 2019
@MartinZikmund MartinZikmund added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2019
@MartinZikmund MartinZikmund removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2019
@MartinZikmund @davidjohnoliver
Updated exception message
5f37003 
Co-Authored-By: David Oliver <david.john.oliver@gmail.com>
@davidjohnoliver davidjohnoliver dismissed jeromelaban’s stale review August 9, 2019 14:58

Changes have been made

@davidjohnoliver davidjohnoliver merged commit e3e9997 into unoplatform:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjohnoliver davidjohnoliver davidjohnoliver approved these changes

@jeromelaban jeromelaban jeromelaban left review comments

Assignees
No one assigned
Labels
platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinZikmund @davidjohnoliver @jeromelaban @ghuntley