Fixed problem with ButtonBase.Click on Android #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carldebilly
added
kind/bug
dr1rrb
approved these changes
Jul 29, 2019
jeromelaban
reviewed
Jul 30, 2019
| { | ||
| this.InitializeComponent(); | ||
|
|
||
| btnTapped.Tapped += (snd, evt) => btnTappedCount.Text = (++_btnTappedCount).ToString(); |
There was a problem hiding this comment.
No UI Tests for that sample ?
There was a problem hiding this comment.
I made some UI tests for Button pointer events, I will merge them once @dr1rrb 's feature branch is merged.
There was a problem hiding this comment.
Yes there's a pretty big one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #1315
Bugfix
What is the current behavior?
On Android, using
ButtonBase.Clickwere not working properly:it was required to register to event
.Tappedfor the click to work properly.What is the new behavior?
.Tappedrequirement removed.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.