Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors setting some properties on root of XAML file #1356

Merged
merged 4 commits into from
Aug 9, 2019

Conversation

carldebilly
Copy link
Member

@carldebilly carldebilly commented Aug 8, 2019

GitHub Issue (If applicable): #718

Bugfix

Description of the bug

Setting a collection-based property on the root of a XAML file like this
were leading to c# compilation errors:

<Grid
	x:Class="XamlGenerationTests.Shared.GridAsRoot"
	xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
	xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"> 
	<Grid.ColumnDefinitions>
		<ColumnDefinition />
	</Grid.ColumnDefinitions>
</Grid>

PR Checklist

Please check if your PR fulfills the following requirements:

@carldebilly carldebilly added the kind/bug Something isn't working label Aug 8, 2019
@carldebilly carldebilly self-assigned this Aug 8, 2019
@carldebilly carldebilly marked this pull request as ready for review August 8, 2019 18:31
@carldebilly carldebilly changed the title Erros setting some properties on root of XAML file Errors setting some properties on root of XAML file Aug 8, 2019
Copy link
Contributor

@davidjohnoliver davidjohnoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of related issues in the backlog. @carldebilly would you mind testing to see if they're fixed so we could close them?

#856
#211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants