Adjust devserver inclusion when WinExe is selected #17974
Conversation
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17974/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17974/index.html |
|
/azp run (net8_uwp_runtimetests_group_01 was stuck even with re-tries) - artifacts of the previous build (https://dev.azure.com/uno-platform/Uno%20Platform/_build/results?buildId=136760&view=artifacts&pathAsName=false&type=publishedArtifacts) |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
No pipelines are associated with this pull request. |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17974/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17974/index.html |
|
The build 136979 found UI Test snapshots differences: Details
|
|
@agneszitte I tried overriding Uno with this change and launched a newly created 5.3 & latest 5.4 dev apps but the console still appears on Desktop skia on Windows. I'm guessing nuget overriding Uno might not be overriding the actual Uno.Sdk project... Not sure how to test this one. Seeing as this PR is labelled draft it might be best to wait on it. |
|
@rajamatt you need to use the packages from the CI, overriding from a local build will not work. You can also test the changes in the cache directly, but it's a manual operation. |
|
Just managed to test this and it is working. I created a blank unoapp with Uno.SDK 5.3.99, replaced the SDK with the one from the CI.
As written in the description of the PR now all OutputTypes (both To compare with the current version, I created another blank unoapp with 5.3.99 but this time I didn't touch the SDK. The cc: @jeromelaban |
jeromelaban
changed the title
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17974/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17974/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17974/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17974/index.html |
|
@Mergifyio backport release/stable/5.4 |
✅ Backports have been created
|
…5.4/pr-17974 Adjust devserver inclusion when WinExe is selected (backport #17974)
GitHub Issue (If applicable): closes #
OutputTypecannot be changed #17719PR Type
What kind of change does this PR introduce?
What is the current behavior?
We limit the WinEXE Output Type to when we are building a release
What is the new behavior?
We always use WinEXE for the Output Type of the Desktop Target for an Uno Head project.
cc: @jeromelaban