[droid] "Uri too long" in WebView.NavigateToString remediation #2023
Conversation
| // step 1: generate long string | ||
| _app.Tap(startButton); | ||
|
|
||
| // _app.Wait(TimeSpan.FromSeconds(300)); // Android: 20 is sufficient |
There was a problem hiding this comment.
Delete the commented code
There was a problem hiding this comment.
Commented code is left by purpose - as for WASM (which is interpreter, not compiler) default timeout can be too short, and maybe adding _Wait would be necessary for this.
But OK, I will delete it (but it means that I have to re-create PR, as I was told that it had to be single commit in PR, and I don't know how to make changes without adding new commit to PR)
There was a problem hiding this comment.
There's no need to recreate the PR. It's fine to add additional commits that address PR feedback.
There was a problem hiding this comment.
There was a problem hiding this comment.
So, one commit per one changed file is ok?
There was a problem hiding this comment.
That's fine in this case.
There was a problem hiding this comment.
Also on the subject of commits - for the future please try to give each one a meaningful commit message. Don't just use the default 'Updated file.cs' when you're using the GitHub web interface.
There was a problem hiding this comment.
All corrections are made.
So, can this PR be approved/merged? :)
...SamplesApp.UITests/Windows_UI_Xaml_Controls/WebViewTests/UnoSamples_Test_NavigateToString.cs
Show resolved
Hide resolved
Changed variable name from _afterToString to _wasLoadedFromString
GitHub Issue (If applicable):
#1527
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When WebView.NavigateToString(long_string)
exception is thrown: "uri too long".
What is the new behavior?
no exception is thrown
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Recreated PR 1732 (as probably only of squashing way available to me).
Many thanks to Sébastien Goyette for helping me in creating tests for this PR.
CI is failing for WASM, as error I corrected on Android still exist on WASM.