fix: View not removed and Unloaded event not raised #3728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dr1rrb
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dr1rrb
force-pushed
the
dev/dr/SkiaLoad
branch
2 times, most recently
from
3d3426d
to
56d3da5
Compare
|
Can you add a runtime test validating the behavior ? |
dr1rrb
force-pushed
the
dev/dr/SkiaLoad
branch
3 times, most recently
from
b49b793
to
ab27ae7
Compare
|
The build 18548 found UI Test snapshots differences: Details
|
dr1rrb
added
the
ready-to-merge
|
The build 18558 found UI Test snapshots differences: Details
|
|
The build 18558 found UI Test snapshots differences: Details
|
|
The build 18558 found UI Test snapshots differences: Details
|
… leaking on WASM, cause the UI test to fail on CI)
dr1rrb
force-pushed
the
dev/dr/SkiaLoad
branch
from
2296b4d
to
b617eab
Compare
|
The build 19642 found UI Test snapshots differences: Details
|
|
The build 19642 found UI Test snapshots differences: Details
|
|
The build 19642 found UI Test snapshots differences: Details
|
|
The build 19642 found UI Test snapshots differences: Details
|
|
The build 19642 found UI Test snapshots differences: Details
|
added 3 commits
September 16, 2020 16:48
|
The build 19651 found UI Test snapshots differences: Details
|
|
The build 19651 found UI Test snapshots differences: Details
|
|
The build 19651 found UI Test snapshots differences: Details
|
|
The build 19651 found UI Test snapshots differences: Details
|
|
The build 19651 found UI Test snapshots differences: Details
|
| internal protected readonly ILogger _log; | ||
| private protected readonly ILogger _logDebug; | ||
|
|
||
| private readonly bool _isFrameworkElement; |
There was a problem hiding this comment.
Codacy found an issue: Remove unassigned field '_isFrameworkElement', or set its value.
| @@ -11,6 +11,7 @@ public partial class UIElement : DependencyObject | |||
| { | |||
| public UIElement() | |||
| { | |||
| _isFrameworkElement = this is FrameworkElement; // Avoids unused field error | |||
There was a problem hiding this comment.
| public UIElement() | ||
| { | ||
| _log = this.Log(); | ||
| _logDebug = _log.IsEnabled(LogLevel.Debug) ? _log : null; | ||
| _isFrameworkElement = this is FrameworkElement; |
There was a problem hiding this comment.
|
The build 19668 found UI Test snapshots differences: Details
|
|
The build 19668 found UI Test snapshots differences: Details
|
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix
Some views, like the
ScrollBarare leakingWhat is the current behavior?
On a given platform the view were not actually removed from the visual tree and the
UIElement.Unloadedevent is not raised.What is the new behavior?
🙃
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.