fix(combobox): PlaceholderText not displaying #3860

Xiaoy312 · 2020-08-21T00:55:51Z

GitHub Issue (If applicable): #3358

PR Type

What kind of change does this PR introduce?

Bugfix

What is the new behavior?

ComboBox.PlaceholderText is now displaying correctly.

PR Checklist

Please check if your PR fulfills the following requirements:

Docs have been added/updated which fit documentation template (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Validated PR Screenshots Compare Test Run results.
Contains NO breaking changes
Associated with an issue (GitHub or internal) and uses the automatic close keywords.
Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):
https://dev.azure.com/nventive/Uno%20Gallery/_queries/edit/191190

gitpod-io · 2020-08-21T00:55:55Z

agneszitte · 2020-08-21T01:28:56Z

You can precise "Fix #3358" in the PR description to close the issue automatically when it's merged.
Also do you think that it should be a good idea to add some additional Uni tests / UI tests for the placeholder ;) ?

Xiaoy312 · 2020-08-21T15:26:46Z

~~Doesnt handle ItemTemplate properly..: StackPanel > (Rectangle + TextBlock)~~

edit: fixed

src/Uno.UI/UI/Xaml/Controls/ContentPresenter/ContentPresenter.cs

src/Uno.UI/UI/Xaml/Controls/ComboBox/ComboBox.cs

nventive-devops · 2020-08-24T22:03:04Z

The build 18918 found UI Test snapshots differences: android-28: 29, android-28-Snap: 11, ios: 22, ios-Snap: 23, skia-gtk-screenshots: 6, wasm: 4, wasm-automated: 5

Details

android-28: 29 changed over 414
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBoxTests_Fullscreen_Popup_Generic_Opened
- Dismiss_MenuFlyout_fileMenu
- Dismiss_MenuFlyout_AfterSuccess
- Keyboard_Textbox_InsideScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
- Keyboard_Textbox_InsideScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
- Keyboard_Textbox_InsideScrollViewer_Validation_3_-_Remove_Focus_on_disabledTextBox
- MenuFlyoutItem_ClickTest_AfterSuccess
- PopupWithOverlay_UITests_Shared_Windows_UI_Xaml_Controls_Popup_Popup_Overlay_On
- MenuFlyoutItem_ClickTest_menuShown
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- Simple_MenuFlyout_openMenu
- Simple_MenuFlyout_AfterSuccess
- Simple_MenuFlyout_exitMenu
- Simple_MenuFlyout_xamlUIMenu
- Simple_SubMenuFlyout_AfterSuccess
- ComboBoxTests_Fullscreen_Popup_Generic_Closed
- Simple_SubMenuFlyout_fileMenu
- Simple_SubMenuFlyout_newMenu
- TextBox_IsReadOnly_AcceptsReturn_Test_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_IsReadOnly_AcceptsReturn
- PopupWithOverlay_After
android-28-Snap: 11 changed over 756
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement
- ListView_HorizontalListView_Padding_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Padding
- ImageBrushTestControl_EllipsemaskingEllipseGrid_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipsemaskingEllipseGrid
- ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
- MediaPlayerElement_Using__avi_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Avi_Extension
- SplitButton_MUX_Test_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonPage
- TextBox_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll
- Time_Picker_TimePicker_TimePickerFlyoutStyle_UITests_Windows_UI_Xaml_Controls_TimePicker_TimePicker_TimePickerFlyoutStyle
- WebView_WebView_WithHeaders_Uno_UI_Samples_Content_UITests_WebView_WebView_WithHeaders
- UIElement_TransformToVisual_Transform_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_Transform
ios: 22 changed over 217
🚨🚨 Comparison Details (first 20) 🚨🚨
- Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
- Large_Image_With_Margin_Ready
- Large_Image_With_Margin_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Margin_Large
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Collapsed_State
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Expanded_State
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Initial_State
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- Screenshots_Image_Stretch_Alignment_Wider_Mode-0
- Keyboard_Textbox_NoScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Collapsed_State
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Expanded_State
- ListView_ExpandableItemLarge_ExpandHeader_Validation_Initial_State
- ListView_ExpandableItemLarge_ExpandHeader_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- DatePicker_Flyout_DatePicker_-_Flyout
- ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
- Keyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Initial_State
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- ListView_ExpandableItemLarge_ExpandHeader_Validation_Collapsed_State
- ListView_ExpandableItemLarge_ExpandHeader_Validation_Expanded_State
ios-Snap: 23 changed over 748
🚨🚨 Comparison Details (first 20) 🚨🚨
- Border_AutoBorderStretchwithbottommargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithbottommargin
- Border_Uniform_Thickness_and_Small_Radius_Uno_UI_Samples_UITests_BorderTestsControl_Uniform_Thickness_and_Small_Radius
- ComboBox_ComboBox_Picker_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Picker
- GridTestsControl_Grid_with_Text_HorizontalAlignment_With_Margin_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_Text_HorizontalAlignment_With_Margin
- MediaPlayerElement_Original_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Original
- MediaPlayerElement_Using__3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- ListView_ListView_Padding_Unconstrained_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Padding_Unconstrained
- ListView_UndefinedHeightListView_SamplesApp_Windows_UI_Xaml_Controls_ListView_UndefinedHeightListView
- MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger
- TextBlockControl_SimpleText_MaxLines_Different_Font_Size_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_SimpleText_MaxLines_Different_Font_Size
- TextBox_TextBox_BeforeTextChanging_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_BeforeTextChanging
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
- TextBlockControl_Simple_Contrained_Horizontal_Center_Wrap2_Uno_UI_Samples_Content_UITests_TextBlockControl_Simple_Contrained_Horizontal_Center_Wrap2
- WebView_WebView_JavascriptInvoke_Uno_UI_Samples_Content_UITests_WebView_WebView_JavascriptInvoke
- WebView_WebView_NavigateToUri_Uno_UI_Samples_Content_UITests_WebView_WebView_NavigateToUri
- TextBox_Input_InputScope_PhoneNumber_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_InputScope_PhoneNumber
- Time_Picker_TimePicker_TimePickerFlyoutStyle_UITests_Windows_UI_Xaml_Controls_TimePicker_TimePicker_TimePickerFlyoutStyle
- ToggleSwitch_ToggleSwitch_IsOn_SamplesApp_Windows_UI_Xaml_Controls_ToggleSwitchControl_ToggleSwitch_IsOn
skia-gtk-screenshots: 6 changed over 741
🚨🚨 Comparison Details (first 20) 🚨🚨
- Image-Image_Stretch
- ImageBrushTestControl-ImageBrushWithCompositeTransform
- ListView-ListViewResizable
- ListView-ListView_Image
- NumberBox-MUX_Test
- _Automation-AutomationProperties_Name
wasm: 4 changed over 757
🚨🚨 Comparison Details (first 20) 🚨🚨
- UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRingPage
- UITests.Shared.Windows_UI_Xaml_Automation.AutomationProperties_Name
- Uno.UI.Samples.Content.UITests.CommandBar.CommandBar_Native
- Uno.UI.Samples.Content.UITests.Transform.Image_With_RotateTransform
wasm-automated: 5 changed over 468
🚨🚨 Comparison Details (first 20) 🚨🚨
- Compact again
- LoadEmptyContentControl_ContentControlNoTemplateNoContent_-_bntContentClear
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- Screenshots_Image_Stretch_Alignment_Smaller_Mode-0
- When_TransformToVisual_ScrollViewer_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_ScrollViewer

nventive-devops · 2020-08-25T15:18:58Z

src/Uno.UI/UI/Xaml/Controls/ComboBox/ComboBox.cs

@@ -248,10 +241,11 @@ internal override void OnItemClicked(int clickedIndex)

 		private void UpdateContentPresenter()
 		{
-			if (_contentPresenter != null)
+			if (_contentPresenter == null) return;


Codacy found an issue: Add curly braces around the nested statement(s) in this 'if' block.

nventive-devops · 2020-08-25T15:18:59Z

src/Uno.UI/UI/Xaml/Controls/ContentPresenter/ContentPresenter.cs

+					DependencyObject FindTemplatedParent()
+					{
+						// ImplicitTextBlock is a special case that requires its TemplatedParent to be the ContentPresenter
+						if (_contentTemplateRoot is ImplicitTextBlock) return this;


Codacy found an issue: Add curly braces around the nested statement(s) in this 'if' block.

nventive-devops · 2020-08-25T17:32:08Z

The build 18937 found UI Test snapshots differences: android-28: 33, android-28-Snap: 13, ios: 21, ios-Snap: 29, skia-gtk-screenshots: 17, wasm: 4, wasm-automated: 8

Details

android-28: 33 changed over 416
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBoxTests_Fullscreen_Popup_Generic_Closed
- CommandBar_LongTitle_Validation_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_LongTitle
- CommandTest_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonPage
- Keyboard_Textbox_InsideScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
- NativeButtonTests_UITests_Shared_Windows_UI_Xaml_Controls_Buttons_Native
- ComboBoxTests_Fullscreen_Popup_Generic_Opened
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_1_-_Initial_State
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_2_-_Orientation_Landscape
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_3_-_Orientation_Portrait
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_4_-_Orientation_Landscape
- Dismiss_MenuFlyout_AfterSuccess
- Dismiss_MenuFlyout_fileMenu
- PopupWithOverlay_UITests_Shared_Windows_UI_Xaml_Controls_Popup_Popup_Overlay_On
- PopupWithOverlay_After
- Simple_MenuFlyout_exitMenu
- Simple_MenuFlyout_openMenu
- Simple_MenuFlyout_Toggle_AfterSuccess
- Simple_MenuFlyout_Toggle_RepeatToggleMenuFlyoutItem
- Simple_MenuFlyout_Toggle_ShuffleToggleMenuFlyoutItem
- Keyboard_Textbox_InsideScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
android-28-Snap: 13 changed over 756
🚨🚨 Comparison Details (first 20) 🚨🚨
- Button_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
- ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement
- ComboBox_ComboBox_PlaceholderText_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_PlaceholderText
- CommandBar_Native_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Native
- MediaPlayerElement_Original_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Original
- MediaPlayerElement_Using__avi_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Avi_Extension
- MediaPlayerElement_Using__mov_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mov_Extension
- MediaPlayerElement_Using__ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- ListView_HorizontalListView_Padding_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Padding
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
- TextBox_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll
- Time_Picker_TimePicker_TimePickerFlyoutStyle_UITests_Windows_UI_Xaml_Controls_TimePicker_TimePicker_TimePickerFlyoutStyle
- UIElement_TransformToVisual_Transform_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_Transform
ios: 21 changed over 217
🚨🚨 Comparison Details (first 20) 🚨🚨
- Keyboard_Textbox_InsideScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
- Screenshots_Image_Stretch_Alignment_SizeOnControl_Mode-0
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Collapsed_State
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Expanded_State
- ListView_ExpandableItemLarge_ExpandHeader_Validation_Initial_State
- ListView_ExpandableItemLarge_ExpandHeader_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- DatePicker_Flyout_DatePicker_-_Flyout
- FlyoutTest_Simple_FlyoutsCanBeDismissed_Uno_UI_Samples_Content_UITests_Flyout_Flyout_Simple
- ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
- Keyboard_Textbox_InsideScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
- Keyboard_Textbox_InsideScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
- Keyboard_Textbox_NoScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
- ListView_ChangingText_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Changing_Text
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Initial_State
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Initial_State
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Collapsed_State
- ListView_ExpandableItemLarge_ExpandHeader_Validation_Collapsed_State
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Expanded_State
ios-Snap: 29 changed over 748
🚨🚨 Comparison Details (first 20) 🚨🚨
- BitmapIcon_BitmapIcon_Generic_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Generic
- Border_AutoBorderStretchwithbottommargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithbottommargin
- Border_Uniform_Thickness_and_Small_Radius_Uno_UI_Samples_UITests_BorderTestsControl_Uniform_Thickness_and_Small_Radius
- ComboBox_ComboBox_NativePopup_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_NativePopup
- ComboBox_ComboBox_Picker_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Picker
- ComboBox_ComboBox_PlaceholderText_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_PlaceholderText
- GridTestsControl_Grid_with_Text_HorizontalAlignment_With_Margin_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_Text_HorizontalAlignment_With_Margin
- ImageBrushTestControl_ImageBrushAlignmentXY_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY
- Image_UniformToFill100x100_Uno_UI_Samples_UITests_ImageTestsControl_UniformToFill100x100
- ImageBrushTestControl_ImageBrushWithRotateTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithRotateTransform
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Uno_UI_Samples_UITests_Image_Image_Stretch
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- MediaPlayerElement_Original_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Original
- MediaPlayerElement_Using__3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- MediaPlayerElement_Using__avi_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Avi_Extension
- MediaPlayerElement_Using__ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
- TextBox_Input_InputScope_PhoneNumber_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_InputScope_PhoneNumber
- ListView_ListView_Padding_Unconstrained_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Padding_Unconstrained
- Slider_Slider_Inside_ListViewHeader_Uno_UI_Samples_Content_UITests_Slider_Slider_Inside_ListViewHeader
skia-gtk-screenshots: 17 changed over 741
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBox-ComboBox_PlaceholderText
- ComboBox-ComboBox_With_ItemTemplate
- ComboBox-ComboBox_ItemDataContext
- Image-Image_Stretch
- Image-Image_Stretch_Algmnt_Inf_Vertical
- ListView-ListViewGroupedLarge
- ListView-ListViewGroupedLargeLegacy
- ListView-ListView_SelectedItem
- Image-Image_Stretch_Alignment_Bigger
- Image-Image_Stretch_Alignment_Smaller
- Image-Image_Stretch_Alignment_Taller
- Image-Image_Stretch_Alignment_Wider
- ListView-ListViewResizable
- ListView-ListViewGrouped
- ListView-ListView_Image
- NumberBox-MUX_Test
- WinUI-MUX_Test
wasm: 4 changed over 757
🚨🚨 Comparison Details (first 20) 🚨🚨
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_With_ItemTemplate
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_PlaceholderText
- UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRingPage
- UITests.Shared.Windows_UI_Xaml_Controls.ComboBox.ComboBox_ItemDataContext
wasm-automated: 8 changed over 468
🚨🚨 Comparison Details (first 20) 🚨🚨
- Compact again
- ListView_Weird_Measure_During_Arrange_after_layout
- LoadEmptyContentControl_ContentControlNoTemplateNoContent_-_bntContentClear
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- Screenshots_Image_Stretch_Alignment_Equal_Mode-0
- Screenshots_Image_Stretch_Alignment_SizeOnControl_Mode-0
- MenuFlyoutItem_ClickTest_menuShown
- NoToolTip_On_Open_opened-textonly-tooltip

nventive-devops · 2020-08-25T20:14:35Z

The build 18937 found UI Test snapshots differences: android-28: 34, android-28-Snap: 14, ios: 25, ios-Snap: 41, skia-gtk-screenshots: 16, wasm: 5, wasm-automated: 9

Details

android-28: 34 changed over 416
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBoxTests_Fullscreen_Popup_Generic_Closed
- ComboBoxTests_Fullscreen_Popup_Generic_Opened
- CommandBar_LongTitle_Validation_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_LongTitle
- CommandTest_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonPage
- Dismiss_MenuFlyout_AfterSuccess
- Keyboard_Textbox_InsideScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Expanded_State
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_1_-_Initial_State
- Dismiss_MenuFlyout_fileMenu
- MenuFlyoutItem_ClickTest_AfterSuccess
- NativeButtonTests_UITests_Shared_Windows_UI_Xaml_Controls_Buttons_Native
- PopupWithOverlay_UITests_Shared_Windows_UI_Xaml_Controls_Popup_Popup_Overlay_On
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_2_-_Orientation_Landscape
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_3_-_Orientation_Portrait
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_4_-_Orientation_Landscape
- Keyboard_Textbox_InsideScrollViewer_Validation_3_-_Remove_Focus_on_disabledTextBox
- PopupWithOverlay_After
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- MenuFlyoutItem_ClickTest_menuShown
- Simple_MenuFlyout_openMenu
android-28-Snap: 14 changed over 756
🚨🚨 Comparison Details (first 20) 🚨🚨
- Button_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
- ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement
- CommandBar_Native_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Native
- ComboBox_ComboBox_PlaceholderText_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_PlaceholderText
- ContentControlTestsControl_ContentControl_Nested_TemplatedParent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Nested_TemplatedParent
- ListView_ListViewChangeView_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewChangeView
- ListView_HorizontalListView_Padding_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Padding
- MediaPlayerElement_Using__avi_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Avi_Extension
- MediaPlayerElement_Using__mov_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mov_Extension
- MediaPlayerElement_Using__ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
- TextBox_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll
- Time_Picker_TimePicker_TimePickerFlyoutStyle_UITests_Windows_UI_Xaml_Controls_TimePicker_TimePicker_TimePickerFlyoutStyle
ios: 25 changed over 217
🚨🚨 Comparison Details (first 20) 🚨🚨
- FlyoutTest_Simple_FlyoutsCanBeDismissed_Uno_UI_Samples_Content_UITests_Flyout_Flyout_Simple
- ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
- ListView_ChangeHeight_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewChangeHeight
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Collapsed_State
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- ListView_ExpandableItemLarge_ExpandHeader_Validation_Collapsed_State
- ListView_ExpandableItemLarge_ExpandHeader_Validation_Expanded_State
- ListView_ExpandableItemLarge_ExpandHeader_Validation_Initial_State
- ListView_ExpandableItemLarge_ExpandHeader_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- Button_IsEnabled_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Button_IsEnabled_Automated
- Keyboard_Textbox_InsideScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
- Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Collapsed_State
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Expanded_State
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Initial_State
- Large_Image_With_Margin_Ready
- Large_Image_With_Margin_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Margin_Large
- When_MaxLines_Changed_Without_TextWrapping_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_SimpleText_MaxLines_Different_Font_Size
ios-Snap: 41 changed over 748
🚨🚨 Comparison Details (first 20) 🚨🚨
- Button_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
- ComboBox_ComboBox_Picker_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Picker
- ComboBox_ComboBox_PlaceholderText_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_PlaceholderText
- GridTestsControl_Grid_with_Fixed_Size_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_Fixed_Size
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical
- ListView_ListView_BoundSelectedItem_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_BoundSelectedItem
- Clipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping
- ComboBox_ComboBox_NativePopup_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_NativePopup
- GridTestsControl_Grid_with_Text_HorizontalAlignment_With_Margin_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_Text_HorizontalAlignment_With_Margin
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider
- MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
- MediaPlayerElement_Using__ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- TextBlockControl_SimpleText_MaxLines_Different_Font_Size_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_SimpleText_MaxLines_Different_Font_Size
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Uno_UI_Samples_UITests_Image_Image_Stretch
- Transform_Image_With_RotateTransform_Uno_UI_Samples_Content_UITests_Transform_Image_With_RotateTransform
- Transform_Rectangle_With_RotateTransform_SamplesApp_Wasm_Windows_UI_Xaml_Media_Transform_Rectangle_With_RotateTransform
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- MediaPlayerElement_Original_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Original
skia-gtk-screenshots: 16 changed over 741
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBox-ComboBox_PlaceholderText
- CommandBar-Native
- ComboBox-ComboBox_ItemDataContext
- ComboBox-ComboBox_With_ItemTemplate
- ListView-ListViewGrouped
- ListView-ListViewResizableText
- Image-Image_Stretch_Alignment_Bigger
- Image-Image_Stretch_Alignment_Smaller
- Image-Image_Stretch_Alignment_Taller
- Image-Image_Stretch_Alignment_Wider
- Image-Image_Stretch
- Image-Image_Stretch_Algmnt_Inf_Horizontal
- ImageBrushTestControl-ImageBrushWithCompositeTransform
- NumberBox-MUX_Test
- Transform-Image_With_RotateTransform
- WinUI-MUX_Test
wasm: 5 changed over 757
🚨🚨 Comparison Details (first 20) 🚨🚨
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_PlaceholderText
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_With_ItemTemplate
- UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRingPage
- UITests.Shared.Windows_UI_Xaml_Automation.AutomationProperties_Name
- UITests.Shared.Windows_UI_Xaml_Controls.ComboBox.ComboBox_ItemDataContext
wasm-automated: 9 changed over 468
🚨🚨 Comparison Details (first 20) 🚨🚨
- FocusManager_GetFocusedElement_ListViewItem_Validation_FocusManager_-_GetFocusedElement_-_ListViewItem_-_2_-_After_Selection
- ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
- ListView_Weird_Measure_During_Arrange_after_layout
- Screenshots_Image_Stretch_Algmnt_Inf_Horizontal_Mode-2
- FocusManager_GetFocusedElement_ListViewItem_LostFocus_Validation_FocusManager_-_LostFocus_-_ListViewItem_-_2_-_Click_outside
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- Simple_SubMenuFlyout_newMenu
- PopupWithOverlay_During
- Screenshots_Image_Stretch_Alignment_SizeOnControl_Mode-0

jeromelaban · 2020-09-02T16:34:58Z

/azp run

azure-pipelines · 2020-09-02T16:35:10Z

Azure Pipelines successfully started running 1 pipeline(s).

jeromelaban · 2020-09-02T16:36:02Z

.../SamplesApp.UITests/Windows_UI_Xaml_Controls/ComboBoxTests/UnoSamples_Tests.ComboBoxTests.cs

+
+		[Test]
+		[AutoRetry]
+		[ActivePlatforms(Platform.Android)]


Why only android ?

nventive-devops · 2020-09-02T19:02:24Z

The build 19124 found UI Test snapshots differences: android-28: 35, android-28-Snap: 11, ios: 27, ios-Snap: 38, skia-gtk-screenshots: 13, wasm: 7, wasm-automated: 6

Details

android-28: 35 changed over 418
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBoxTests_Fullscreen_Popup_Generic_Opened
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_1_-_Initial_State
- CommandTest_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonPage
- Dismiss_MenuFlyout_AfterSuccess
- Dismiss_MenuFlyout_fileMenu
- Keyboard_Textbox_InsideScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
- MenuFlyoutItem_ClickTest_AfterSuccess
- MenuFlyoutItem_ClickTest_menuShown
- ComboBoxTests_ToggleDisabled_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_ToggleDisabled
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_4_-_Orientation_Landscape
- CommandBar_LongTitle_Validation_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_LongTitle
- PopupWithOverlay_After
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_2_-_Orientation_Landscape
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_3_-_Orientation_Portrait
- ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
- Keyboard_Textbox_NoScrollViewer_Validation_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_Test_NoScrollViewer_Automated
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- Simple_MenuFlyout_xamlUIMenu
- Simple_SubMenuFlyout_AfterSuccess
- Simple_SubMenuFlyout_fileMenu
android-28-Snap: 11 changed over 756
🚨🚨 Comparison Details (first 20) 🚨🚨
- Default_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
- Button_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
- ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement
- ComboBox_ComboBox_PlaceholderText_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_PlaceholderText
- ImageBrushTestControl_EllipsemaskingEllipseGrid_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipsemaskingEllipseGrid
- MediaPlayerElement_Using__mov_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mov_Extension
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
- ListView_ListViewChangeView_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewChangeView
- Image_UniformToFill100x100_Uno_UI_Samples_UITests_ImageTestsControl_UniformToFill100x100
- TextBox_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll
- Time_Picker_TimePicker_TimePickerFlyoutStyle_UITests_Windows_UI_Xaml_Controls_TimePicker_TimePicker_TimePickerFlyoutStyle
ios: 27 changed over 217
🚨🚨 Comparison Details (first 20) 🚨🚨
- Keyboard_Textbox_InsideScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
- Keyboard_Textbox_InsideScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
- Keyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
- Keyboard_Textbox_NoScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Collapsed_State
- Screenshots_Image_Stretch_Alignment_Equal_Mode-0
- Screenshots_Image_Stretch_Alignment_Wider_Mode-0
- Keyboard_Textbox_InsideScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
- Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
- Keyboard_Textbox_NoScrollViewer_Validation_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_Test_NoScrollViewer_Automated
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Collapsed_State
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Expanded_State
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Initial_State
- ListView_ExpandableItemLarge_ExpandHeader_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- Keyboard_Textbox_InsideScrollViewer_Validation_3_-_Remove_Focus_on_disabledTextBox
- Keyboard_Textbox_InsideScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
- Keyboard_Textbox_InsideScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
- Keyboard_Textbox_InsideScrollViewer_Validation_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_Test_InsideScrollerViewer_Automated
- Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
ios-Snap: 38 changed over 748
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBox_ComboBox_NativePopup_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_NativePopup
- ComboBox_ComboBox_Picker_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Picker
- ComboBox_ComboBox_PlaceholderText_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_PlaceholderText
- ContentControlTestsControl_ContentControl_Nested_TemplatedParent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Nested_TemplatedParent
- ContentPresenter_ContentPresenter_Background_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Background
- ContentControlTestsControl_ContentControl_SetNull_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_SetNull
- GridTestsControl_Grid_with_Fixed_Size_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_Fixed_Size
- GridTestsControl_Grid_with_UserControl_VerticalAlignment_Fixed_Height_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_UserControl_VerticalAlignment_Fixed_Height
- ImageBrushTestControl_ImageBrushWithRotateTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithRotateTransform
- Image_Image_Stretch_None_ScrollViewer_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None_Containers
- Image_StretchNoneBoundingBoxInDoubleStackPanel_Uno_UI_Samples_UITests_ImageTestsControl_StretchNoneBoundingBoxInDoubleStackPanel
- ListView_ListView_BoundSelectedItem_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_BoundSelectedItem
- ListView_ListView_Changing_Text_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Changing_Text
- GridTestsControl_Grid_with_Stack_Panel_and_Trimming_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_Stack_Panel_and_Trimming
- Image_ImageUniformWithinScrollViewer_Uno_UI_Samples_UITests_ImageTestsControl_ImageUniformWithinScrollViewer
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal
- MediaPlayerElement_Original_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Original
- MediaPlayerElement_Using__3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- MediaPlayerElement_Using__mov_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mov_Extension
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical
skia-gtk-screenshots: 13 changed over 741
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBox-ComboBox_With_ItemTemplate
- ComboBox-ComboBox_ItemDataContext
- CommandBar-Native
- ComboBox-ComboBox_PlaceholderText
- Image-Image_Stretch_Alignment_Bigger
- Image-Image_Stretch_Algmnt_Inf_Horizontal
- ListView-ListView_Image
- NumberBox-MUX_Test
- ListView-ListViewResizableText
- ListView-ListView_SelectedItem
- Image-UniformToFill100x100
- WinUI-MUX_Test
- TwoPaneView-MUX_Test
wasm: 7 changed over 757
🚨🚨 Comparison Details (first 20) 🚨🚨
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_PlaceholderText
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_With_ItemTemplate
- UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRingPage
- UITests.Shared.Windows_UI_Xaml_Automation.AutomationProperties_Name
- UITests.Shared.Windows_UI_Xaml_Controls.ComboBox.ComboBox_ItemDataContext
- Uno.UI.Samples.Content.UITests.Transform.Image_With_RotateTransform
- Uno.UI.Samples.UITests.Image.Image_Stretch
wasm-automated: 6 changed over 469
🚨🚨 Comparison Details (first 20) 🚨🚨
- ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
- FocusManager_GetFocusedElement_ComboBoxItem_LostFocus_Validation_FocusManager_-_LostFocus_-_ComboBoxItem_-_2_-_Click_outside
- Screenshots_Image_Stretch_Alignment_SizeOnControl_Mode-0
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- LoadEmptyContentControl_ContentControlNoTemplateNoContent_-_bntContentClear
- Simple_SubMenuFlyout_newMenu

nventive-devops · 2020-09-02T20:01:59Z

The build 19124 found UI Test snapshots differences: android-28: 33, android-28-Snap: 14, ios: 7, ios-Snap: 27, skia-gtk-screenshots: 11, wasm: 5, wasm-automated: 7

Details

android-28: 33 changed over 418
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBoxTests_Fullscreen_Popup_Generic_Closed
- ComboBoxTests_Fullscreen_Popup_Generic_Opened
- Keyboard_Textbox_NoScrollViewer_Validation_3_-_Remove_Focus_on_disabledTextBox
- Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
- Keyboard_Textbox_NoScrollViewer_Validation_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_Test_NoScrollViewer_Automated
- Dismiss_MenuFlyout_fileMenu
- Keyboard_Textbox_InsideScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
- Keyboard_Textbox_InsideScrollViewer_Validation_3_-_Remove_Focus_on_disabledTextBox
- Keyboard_Textbox_InsideScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
- Keyboard_Textbox_NoScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
- MenuFlyoutItem_ClickTest_AfterSuccess
- MenuFlyoutItem_ClickTest_menuShown
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_3_-_Orientation_Portrait
- Dismiss_MenuFlyout_AfterSuccess
- PopupWithOverlay_After
- PopupWithOverlay_UITests_Shared_Windows_UI_Xaml_Controls_Popup_Popup_Overlay_On
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- Simple_MenuFlyout_exitMenu
- Simple_MenuFlyout_openMenu
- Simple_MenuFlyout_Toggle_AfterSuccess
android-28-Snap: 14 changed over 756
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBox_ComboBox_PlaceholderText_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_PlaceholderText
- ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement
- Button_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
- ImageBrushTestControl_EllipsemaskingEllipseGrid_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipsemaskingEllipseGrid
- ListView_HorizontalListView_Padding_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Padding
- Image_UniformToFill100x100_Uno_UI_Samples_UITests_ImageTestsControl_UniformToFill100x100
- MediaPlayerElement_Original_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Original
- MediaPlayerElement_Using__avi_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Avi_Extension
- MediaPlayerElement_Using__mov_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mov_Extension
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
- TextBox_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll
- Time_Picker_TimePicker_TimePickerFlyoutStyle_UITests_Windows_UI_Xaml_Controls_TimePicker_TimePicker_TimePickerFlyoutStyle
- UIElement_TransformToVisual_Simple_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_Simple
- XBind_Phase_Large_Uno_UI_Samples_Content_UITests_XBind_PhaseBinding_Large
ios: 7 changed over 217
🚨🚨 Comparison Details (first 20) 🚨🚨
- Keyboard_Textbox_InsideScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
- Keyboard_Textbox_NoScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
- Screenshots_Image_Stretch_Alignment_Taller_Mode-0
- Screenshots_Image_Stretch_Alignment_Wider_Mode-0
- FlyoutTest_Simple_FlyoutsCanBeDismissed_Uno_UI_Samples_Content_UITests_Flyout_Flyout_Simple
- Keyboard_Textbox_InsideScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
- Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
ios-Snap: 27 changed over 748
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBox_ComboBox_PlaceholderText_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_PlaceholderText
- ComboBox_ComboBox_Picker_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Picker
- GridTestsControl_Grid_with_UILabel_TextAlignmentVertical_Bottom_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_UILabel_TextAlignmentVertical_Bottom
- ListView_ListViewHeaderImage_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderImage
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical
- ListView_ListView_Changing_Text_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Changing_Text
- MediaPlayerElement_Original_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Original
- MediaPlayerElement_Using__3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- GridTestsControl_Grid_with_UserControl_VerticalAlignment_Variable_Height_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_UserControl_VerticalAlignment_Variable_Height
- ListView_ListViewMarginTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewMarginTest
- PathTestsControl_PathVerticalOffsetII_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_PathVerticalOffsetII
- GridTestsControl_Grid_with_Fixed_Size_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_Fixed_Size
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
- TextBlockControl_TextBlockMultilineInStarStackPanel_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlockMultilineInStarStackPanel
- TextBlockControl_TextBlock_LineHeight_Inlines_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_LineHeight_Inlines
- WebView_Javascript_AlertConfirmPrompt_Uno_UI_Samples_Content_UITests_WebView_WebViewControlJavaScriptAlertConfirmPrompt
- WebView_WebView_JavascriptInvoke_Uno_UI_Samples_Content_UITests_WebView_WebView_JavascriptInvoke
- WebView_WebView_NavigateToUri_Uno_UI_Samples_Content_UITests_WebView_WebView_NavigateToUri
skia-gtk-screenshots: 11 changed over 741
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBox-ComboBox_ItemDataContext
- ComboBox-ComboBox_PlaceholderText
- ComboBox-ComboBox_With_ItemTemplate
- ListView-ListView_Image
- Image-Image_Stretch_Algmnt_Inf_Vertical
- ListView-ListView_SelectedItem
- ListView-ListViewResizableText
- TwoPaneView-MUX_Test
- ToggleSwitch-ToggleSwitch_TemplateReuse
- _Automation-AutomationProperties_Name
- WinUI-MUX_Test
wasm: 5 changed over 757
🚨🚨 Comparison Details (first 20) 🚨🚨
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_With_ItemTemplate
- UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRingPage
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_PlaceholderText
- UITests.Shared.Windows_UI_Xaml_Controls.ComboBox.ComboBox_ItemDataContext
- Uno.UI.Samples.UITests.Image.Image_Stretch
wasm-automated: 7 changed over 469
🚨🚨 Comparison Details (first 20) 🚨🚨
- ListView_Weird_Measure_During_Arrange_after_layout
- MenuFlyoutItem_ClickTest_menuShown
- PopupWithOverlay_During
- Simple_ContentDialog_06_Reuse_Primary_Button
- When_TransformToVisual_ScrollViewer_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_ScrollViewer
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- Simple_SubMenuFlyout_newMenu

Xiaoy312 requested a review from a team August 21, 2020 00:55

agneszitte approved these changes Aug 21, 2020

View reviewed changes

Xiaoy312 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2020

XiaotianNetlift force-pushed the dev/xygu/3358/combobox-placeholdertext branch from 63a6d15 to aff2d75 Compare August 21, 2020 16:33

Xiaoy312 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2020

Xiaoy312 requested a review from agneszitte August 21, 2020 22:05

agneszitte requested review from carldebilly, dr1rrb, alextrepa, LHuss and ajpinedam August 21, 2020 22:08

XiaotianNetlift force-pushed the dev/xygu/3358/combobox-placeholdertext branch 2 times, most recently from 87745be to b680cff Compare August 21, 2020 22:09

dr1rrb approved these changes Aug 21, 2020

View reviewed changes

src/Uno.UI/UI/Xaml/Controls/ContentPresenter/ContentPresenter.cs Outdated Show resolved Hide resolved

src/Uno.UI/UI/Xaml/Controls/ComboBox/ComboBox.cs Outdated Show resolved Hide resolved

src/Uno.UI/UI/Xaml/Controls/ComboBox/ComboBox.cs Outdated Show resolved Hide resolved

davidjohnoliver reviewed Aug 24, 2020

View reviewed changes

src/Uno.UI/UI/Xaml/Controls/ComboBox/ComboBox.cs Outdated Show resolved Hide resolved

src/Uno.UI/UI/Xaml/Controls/ComboBox/ComboBox.cs Outdated Show resolved Hide resolved

XiaotianNetlift force-pushed the dev/xygu/3358/combobox-placeholdertext branch from 3870dd8 to 4899775 Compare August 24, 2020 21:38

Xiaoy312 linked an issue Aug 24, 2020 that may be closed by this pull request

[All Platforms] ComboBox PlaceholderText is not displayed by default #3358

Closed

11 tasks

unoplatform deleted a comment from nventive-devops Aug 24, 2020

Xiaoy312 requested a review from davidjohnoliver August 24, 2020 21:40

Xiaoy312 requested a review from dr1rrb August 24, 2020 21:40

Xiaoy312 added 2 commits August 25, 2020 11:12

fix(combobox): PlaceholderText not displaying

c4c1109

test(ComboBox): added tests for PlaceholderText

bbe5e47

XiaotianNetlift force-pushed the dev/xygu/3358/combobox-placeholdertext branch from 4899775 to bbe5e47 Compare August 25, 2020 15:13

nventive-devops reviewed Aug 25, 2020

View reviewed changes

Xiaoy312 added the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label Aug 27, 2020

jeromelaban approved these changes Sep 2, 2020

View reviewed changes

mergify bot merged commit c820ccb into master Sep 2, 2020

mergify bot deleted the dev/xygu/3358/combobox-placeholdertext branch September 2, 2020 20:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(combobox): PlaceholderText not displaying #3860

fix(combobox): PlaceholderText not displaying #3860

Xiaoy312 commented Aug 21, 2020

gitpod-io bot commented Aug 21, 2020 •

edited

Loading

agneszitte commented Aug 21, 2020

Xiaoy312 commented Aug 21, 2020 •

edited

Loading

nventive-devops commented Aug 24, 2020

nventive-devops Aug 25, 2020

nventive-devops Aug 25, 2020

nventive-devops commented Aug 25, 2020

nventive-devops commented Aug 25, 2020

jeromelaban commented Sep 2, 2020

azure-pipelines bot commented Sep 2, 2020

jeromelaban Sep 2, 2020

nventive-devops commented Sep 2, 2020

nventive-devops commented Sep 2, 2020

fix(combobox): PlaceholderText not displaying #3860

fix(combobox): PlaceholderText not displaying #3860

Conversation

Xiaoy312 commented Aug 21, 2020

PR Type

What is the new behavior?

PR Checklist

Other information

gitpod-io bot commented Aug 21, 2020 • edited Loading

agneszitte commented Aug 21, 2020

Xiaoy312 commented Aug 21, 2020 • edited Loading

nventive-devops commented Aug 24, 2020

nventive-devops Aug 25, 2020

Choose a reason for hiding this comment

nventive-devops Aug 25, 2020

Choose a reason for hiding this comment

nventive-devops commented Aug 25, 2020

nventive-devops commented Aug 25, 2020

jeromelaban commented Sep 2, 2020

azure-pipelines bot commented Sep 2, 2020

jeromelaban Sep 2, 2020

Choose a reason for hiding this comment

nventive-devops commented Sep 2, 2020

nventive-devops commented Sep 2, 2020

gitpod-io bot commented Aug 21, 2020 •

edited

Loading

Xiaoy312 commented Aug 21, 2020 •

edited

Loading