feat: Add support for C# 9.0 source generators #4201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jeromelaban
added
the
do-not-merge/work-in-progress
|
The build 20194 found UI Test snapshots differences: Details
|
carldebilly
reviewed
Oct 1, 2020
src/Directory.Build.props
Outdated
| @@ -21,7 +21,7 @@ | |||
| <CreateHardLinksForAdditionalFilesIfPossible>true</CreateHardLinksForAdditionalFilesIfPossible> | |||
| <CreateHardLinksForPublishFilesIfPossible>true</CreateHardLinksForPublishFilesIfPossible> | |||
|
|
|||
| <LangVersion>8.0</LangVersion> | |||
| <LangVersion>preview</LangVersion> | |||
There was a problem hiding this comment.
Do we really want to merge this into ' master'?
src/Uno.UI/Uno.UI.Skia.csproj
Outdated
| <PackageReference Include="Uno.Core.Build" /> | ||
| <!--<PackageReference Include="Uno.SourceGenerationTasks" />--> |
|
The build 20194 found UI Test snapshots differences: Details
|
|
The build 20194 found UI Test snapshots differences: Details
|
|
The build 20194 found UI Test snapshots differences: Details
|
|
The build 20194 found UI Test snapshots differences: Details
|
jeromelaban
force-pushed
the
dev/jela/cs9
branch
from
a3ee23a to
7730cdd
Compare
|
The build 20211 found UI Test snapshots differences: Details
|
|
The build 20211 found UI Test snapshots differences: Details
|
|
The build 20211 found UI Test snapshots differences: Details
|
|
The build 20211 found UI Test snapshots differences: Details
|
|
The build 20211 found UI Test snapshots differences: Details
|
|
The build 20220 found UI Test snapshots differences: Details
|
jeromelaban
force-pushed
the
dev/jela/cs9
branch
from
52a4f04 to
725062b
Compare
|
The build 20221 found UI Test snapshots differences: Details
|
|
The build 20221 found UI Test snapshots differences: Details
|
|
The build 20221 found UI Test snapshots differences: Details
|
|
The build 20221 found UI Test snapshots differences: Details
|
jeromelaban
force-pushed
the
dev/jela/cs9
branch
from
725062b to
cf4f448
Compare
|
The build 20225 found UI Test snapshots differences: Details
|
|
The build 20227 found UI Test snapshots differences: Details
|
|
The build 20227 found UI Test snapshots differences: Details
|
|
The build 20227 found UI Test snapshots differences: Details
|
jeromelaban
force-pushed
the
dev/jela/cs9
branch
from
182152d to
f100d55
Compare
|
The build 20235 found UI Test snapshots differences: Details
|
|
The build 20235 found UI Test snapshots differences: Details
|
|
The build 20440 found UI Test snapshots differences: Details
|
jeromelaban
force-pushed
the
dev/jela/cs9
branch
from
be361b3 to
1349772
Compare
|
The build 20477 found UI Test snapshots differences: Details
|
|
The build 20477 found UI Test snapshots differences: Details
|
|
The build 20477 found UI Test snapshots differences: Details
|
|
The build 20477 found UI Test snapshots differences: Details
|
|
The build 20477 found UI Test snapshots differences: Details
|
jeromelaban
force-pushed
the
dev/jela/cs9
branch
3 times, most recently
from
0746982 to
a2d4bd5
Compare
|
The build 20536 found UI Test snapshots differences: Details
|
|
The build 20536 found UI Test snapshots differences: Details
|
jeromelaban
force-pushed
the
dev/jela/cs9
branch
from
29353ad to
4a0d9ed
Compare
| { | ||
| var telemetryOptOut = msbProject.GetProperty("UnoPlatformTelemetryOptOut")?.EvaluatedValue ?? ""; | ||
| var telemetryOptOut = context.GetMSBuildPropertyValue("UnoPlatformTelemetryOptOut"); |
There was a problem hiding this comment.
Codacy found an issue: Remove this useless assignment to local variable 'telemetryOptOut'.
| if (parametersType.GetType().GetProperty("Layout", System.Reflection.BindingFlags.Instance | System.Reflection.BindingFlags.NonPublic) is PropertyInfo info) | ||
| var actualSymbol = GetActualSymbol(parametersType); | ||
|
|
||
| if (actualSymbol.GetType().GetProperty("Layout", System.Reflection.BindingFlags.Instance | System.Reflection.BindingFlags.NonPublic) is PropertyInfo info) |
There was a problem hiding this comment.
Codacy found an issue: Make sure that this accessibility bypass is safe here.
| context.AddSource(tree.Key, tree.Value); | ||
|
|
||
| // Uncomment to output the generated files to a separate folder | ||
| // var intermediatePath = context.GetMSBuildPropertyValue("IntermediateOutputPath"); |
There was a problem hiding this comment.
Codacy found an issue: Remove this commented out code.
| /// <returns></returns> | ||
| private object GetActualSymbol(ISymbol symbol) | ||
| { | ||
| if (symbol.GetType().GetProperty("UnderlyingSymbol", System.Reflection.BindingFlags.Instance | System.Reflection.BindingFlags.NonPublic) is PropertyInfo info) |
There was a problem hiding this comment.
Codacy found an issue: Make sure that this accessibility bypass is safe here.
| { | ||
| // Debugger.Launch(); |
There was a problem hiding this comment.
Codacy found an issue: Remove this commented out code.
|
|
||
| var msBuildProjectDirectory = context.GetMSBuildPropertyValue("MSBuildProjectDirectory"); |
There was a problem hiding this comment.
Codacy found an issue: Remove this useless assignment to local variable 'msBuildProjectDirectory'.
| // No initialization required for this one | ||
| //if (!Process.GetCurrentProcess().ProcessName.Equals("devenv", StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| // Debugger.Launch(); |
There was a problem hiding this comment.
Codacy found an issue: Remove this commented out code.
| { | ||
| // Kept until dependencies can be added automatically and this is not needed anymore | ||
| // | ||
| // var assemblyName = typeof(DependenciesInitializer).Assembly.GetName().Name; |
There was a problem hiding this comment.
Codacy found an issue: Remove this commented out code.
|
The build 20563 found UI Test snapshots differences: Details
|
|
The build 20563 found UI Test snapshots differences: Details
|
jeromelaban
removed
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): fixes #3948
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Adds support for C# 9.0 source generators where available.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):