Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: InMemoryRandomAccessStream #9622

Conversation

workgroupengineering
Copy link
Contributor

@workgroupengineering workgroupengineering commented Aug 26, 2022

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@gitpod-io
Copy link

gitpod-io bot commented Aug 26, 2022

Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you also add some unit or runtime tests ?

src/Uno.UWP/Storage/Streams/InMemoryRandomAccessStream.cs Outdated Show resolved Hide resolved
src/Uno.UWP/Storage/Streams/InMemoryRandomAccessStream.cs Outdated Show resolved Hide resolved
@workgroupengineering workgroupengineering marked this pull request as ready for review August 29, 2022 09:35
@workgroupengineering workgroupengineering force-pushed the features/Core/InMemoryRandomAccessStream branch from 20dd599 to e562016 Compare August 29, 2022 17:42
@jeromelaban
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jeromelaban jeromelaban merged commit ac0c34e into unoplatform:master Aug 30, 2022
@workgroupengineering workgroupengineering deleted the features/Core/InMemoryRandomAccessStream branch August 30, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants