docs: adding contribution guide #413
Conversation
| ### CSS Classes | ||
| There are cases when we want to accept `class` as a prop in our `shadcn/vue` components and then combine it with a default style on our `radix-vue` component. | ||
|
|
||
| In these cases, we can not use `v-bind` while `class` is declared as a prop, because this would lead in [double class binding](https://github.com/radix-vue/shadcn-vue/pull/241), so the `class` propert must be dealt specefically. |
There was a problem hiding this comment.
In these cases, we can not use
v-bindwhileclassis declared as a prop, because this would lead in double class binding, so theclasspropert must be dealt specefically.
We can use v-bind when class is declared as prop
we only use this way to prevent class duplication with cn function
There was a problem hiding this comment.
Yup. As long as we have class as prop, we can use v-bind 😁
There was a problem hiding this comment.
Thanks for the feedback ! I tried to be more clear on this one.
There was a problem hiding this comment.
I also added some additional information based on CONTRIBUTING.md.
|
This is so nice Saeid 💯 Also I would add these changes to |
|
Some information in |
Please edit or add any other parts that you see fit.
resolves #409.