fix: sort CSP directives to have deterministic results - necessary specifically when asserting header values #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecifically when asserting header values
DeepDiver1975
changed the title
|
Mind leaving a comment why this change is not accepted? |
|
It was unclear why this change was needed. Was the goal to have the directives sorted, or to have a more explicit test? |
|
The goal is to have the directives sorted. The test was added to proof that. Without sorting the directives the result is not deterministic and asserting header values in tests is quite hard in such a setup. THX |
|
Ahhh I just checked the spec and see what you mean. I'll get the change in right away. In the future a PR description would be helpful in providing context as to why the change is needed. Thanks! |
|
Nice. I was not aware of the spec with respect to the sort order. In any case we got it sorted 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.