Added support for removing/resetting all flag values in a given FlagValueSource
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bok-
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Description
Added
FlagPole.removeFlagValues(in:)to be able to remove / clear / reset all of the values in a givenFlagValueSource. It works by discovering all of the non-nil flag keys inside theFlagValueSourceand then setting it tonil.📓 Documentation Plan
A separate PR is coming today to uplift the whole documentation site to DocC. The new options will be included then. (Reinstalling swift-doc on my new Mac is harder than I remember)
🗳 Test Plan
Additional tests were added
🧯 Source Impact
This change is additive only.
✅ Checklist