Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially mistaken dependency react-react #66

Closed
jeduan opened this issue Apr 6, 2024 · 2 comments · Fixed by #67
Closed

Potentially mistaken dependency react-react #66

jeduan opened this issue Apr 6, 2024 · 2 comments · Fixed by #67

Comments

@jeduan
Copy link

jeduan commented Apr 6, 2024

Hi!

I'm learning how to use react server components and this repo has been a great help.

I noticed that mfng/core includes a peerDependency to react-react. I wasn't familiar with the package but it's a "state management toolkit for react" that supports only up to react 16.

"react-react": "*",

I found this because installing the package had a warning

❯ pnpm add @mfng/core
Packages: +4
++++
Progress: resolved 121, reused 121, downloaded 0, added 0, done

dependencies:
+ @mfng/core 4.1.2

 WARN  Issues with peer dependencies found
 WARN  Issues with peer dependencies found
.
└─┬ react-react 1.2.0
  └── ✕ unmet peer react@"^14.0.0 || ^15.0.0 || ^16.0.0": found 18.3.0-canary-c3048aab4-20240326

Was it the intention to add a peerDependency on this package?

@unstubbable
Copy link
Owner

Thanks for the report! This was indeed unintentional.

@jeduan
Copy link
Author

jeduan commented Apr 7, 2024

@unstubbable Wow, thank you for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants