scriptdata bad testcase

[untitaker]

No description provided.

[untitaker]

seems that lychee handles those cases by excluding the script tag from scraping, but that's actually a bug in html5gum. the contents of script tags shouldn't be interpreted as HTML at all.

https://github.com/lycheeverse/lychee/blob/eff77d634283610dbdd481db2d9b1d1162cdea84/lychee-lib/src/extract/html/mod.rs#L44

cc @mre

[untitaker]

untitaker/html5gum#98

[mre]

Thanks for the info. Could you remind me once this is merged or maybe even update the code in lychee? 🙃

[untitaker]

sure

[untitaker]

html5gum 0.6.1 is out, and can be bumped in lychee. I guess dependabot will do it, there shouldn't be any code changes required. You may want to check out CallbackEmitter if you want to simplify some code, though it has a bit of overhead (still way faster than most other things)

For some reason it's not possible to hit this bug in lychee. I don't know why, but the code I linked earlier is not related. I guess it doesn't matter.

[mre]

Cool. Let's wait until the update comes through, then. 👍