Passing labels to text_decoder to compute loss. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Passing labels to the text decoder is not enough. |
ashvardanian
pushed a commit
that referenced
this pull request
Feb 23, 2024
## [1.1.1](v1.1.0...v1.1.1) (2024-02-23) ### Docs * Performance observations for M2 CPUs (#56) ([8374ef6](8374ef6)), closes [#56](#56) ### Fix * Passing labels to `text_decoder` to compute loss. (#65) ([f445a8b](f445a8b)), closes [#65](#65) ### Improve * Larger batch benchmarks ([fdc8587](fdc8587)) ### Make * pre-commit config and linters (#62) ([0a3efac](0a3efac)), closes [#62](#62)
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed, that labels variable is not passed to text_decoder in VLMForCausalLM.forward(). So text_decoder will return just logits and will not compute loss. This makes impossible to use VLMForCausalLM model with transformer.Trainer and requires to write custom train loop or wrap VLMForCausalLM.
There is a fix to avoid that incompatibility.