Fix payment form breaking after error message #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you submit for example invoice paylater without agreeing to the data processing, you get an error via showError() in the payment methods `_onCreateResource()`. However `showError()` never sets `submitting` back to `false`, so any clicks on the submit button after an error never get any error processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you submit for example invoice paylater without agreeing to the data processing, you get an error via showError() in the payment methods
_onCreateResource().However
showError()never setssubmittingback tofalse, so any clicks on the submit button after an error never get any processing andunzerResourceIdnever gets assigned any value, completely bricking the transaction.--
As an aside, I don't believe setting the submit button blindly to be active in
showError()makes much sense either as quite a few payment methods disable that button by default. However fixing and investigating that for every single payment method was out of scope for this PR.