Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MQ User resource v5.31.0 #236

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

mergenci
Copy link
Collaborator

@mergenci mergenci commented May 14, 2024

Description

MQ User resource is currently managed inside MQ Broker resource. This PR implements MQ User as an independent resource. Note that a Broker restart is required for any MQ User operations to take effect.

References

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mergenci for introducing the aws_mq_user resource. We had better avoid any dependency changes in the go.mod files. Was this a side effect of changing the base?

tools/tfsdk2fw/go.mod Outdated Show resolved Hide resolved
.ci/tools/go.mod Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
@mergenci mergenci changed the base branch from upjet-v5.50.0 to upjet-v5.31.0 May 21, 2024 17:52
@github-actions github-actions bot removed documentation Improvements or additions to documentation linter provider sweeper service/support labels May 21, 2024
@mergenci mergenci changed the title Add MQ User resource Add MQ User resource v5.31.0 May 21, 2024
Copy link
Collaborator

@erhancagirici erhancagirici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mergenci many thanks for the great work. This also serves as a good reference for new TF resource implementations. LGTM!
A small but important note is: in a follow-up, it would be nice to document/automate this process for version bumps.

internal/service/mq/user.go Show resolved Hide resolved
internal/service/mq/user.go Show resolved Hide resolved
@mergenci
Copy link
Collaborator Author

Thanks for your reviews @ulucinar and @erhancagirici 🙏

@mergenci mergenci merged commit 6c8577b into upbound:upjet-v5.31.0 May 23, 2024
86 of 110 checks passed
@mergenci mergenci deleted the f-mq-user branch May 23, 2024 12:16
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants