-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MQ User resource v5.31.0 #236
Conversation
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mergenci for introducing the aws_mq_user
resource. We had better avoid any dependency changes in the go.mod files. Was this a side effect of changing the base?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mergenci many thanks for the great work. This also serves as a good reference for new TF resource implementations. LGTM!
A small but important note is: in a follow-up, it would be nice to document/automate this process for version bumps.
Thanks for your reviews @ulucinar and @erhancagirici 🙏 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
MQ User resource is currently managed inside MQ Broker resource. This PR implements MQ User as an independent resource. Note that a Broker restart is required for any MQ User operations to take effect.
References