Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase onto v5.58.0 #273

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Jul 17, 2024

Description

This PR rebases existing changes (xpprovider/xpprovider.go, internal/conns/awsclient_xp.go, and MQ User implementation) onto upstream v5.58.0.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @turkenf 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@turkenf turkenf force-pushed the prepare-upjet-v5.58.0 branch from 41b7023 to 101595b Compare July 18, 2024 12:10
ulucinar and others added 3 commits July 18, 2024 15:10
some provider internals.

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
@turkenf turkenf force-pushed the prepare-upjet-v5.58.0 branch from 101595b to 7418ffd Compare July 18, 2024 12:10
Copy link
Collaborator

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For future reference, we prepared this PR by running these commands:

git checkout upjet-v5.50.0
git checkout -b upjet-v5.58.0
git fetch hashicorp
git rebase v5.58.0

@turkenf turkenf merged commit dde2a60 into upbound:upjet-v5.58.0 Jul 18, 2024
13 of 22 checks passed
@turkenf turkenf deleted the prepare-upjet-v5.58.0 branch July 18, 2024 12:31
@mergenci mergenci changed the title Copy xpprovider/xpprovider.go and internal/conns/awsclient_xp.go to expose some provider internals Rebase onto v5.58.0 Jul 18, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants