Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement deprecated diagnostic helper function locally #275

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

mergenci
Copy link
Collaborator

@mergenci mergenci commented Oct 7, 2024

Description

Implement the deprecated DiagErrorFramework function locally.

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Copy link

github-actions bot commented Oct 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mergenci 🙌

@mergenci mergenci merged commit 459ac5f into upbound:upjet-v5.70.0 Oct 7, 2024
20 of 27 checks passed
@mergenci mergenci deleted the upbound-upjet-v5.70.0 branch October 7, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants